mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2025-01-12 21:37:32 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

🐛 Fix issue that binary data got reused

Browse source
This commit is contained in:
Jan Oberhauser 2020-12-25 22:59:22 +01:00
parent 530294aa45
commit 5c83be18a8
1 changed files with 2 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
packages/nodes-base/nodes/HttpRequest.node.ts
View file

@ -927,7 +927,7 @@ export class HttpRequest implements INodeType {
newItem.binary![dataPropertyName] = await this.helpers.prepareBinaryData(response!, fileName); newItem.binary![dataPropertyName] = await this.helpers.prepareBinaryData(response!, fileName);
} }
items[itemIndex] = newItem; returnItems.push(newItem);
} else if (responseFormat === 'string') { } else if (responseFormat === 'string') {
const dataPropertyName = this.getNodeParameter('dataPropertyName', 0) as string; const dataPropertyName = this.getNodeParameter('dataPropertyName', 0) as string;
@ -980,12 +980,6 @@ export class HttpRequest implements INodeType {
} }
} }
if (responseFormat === 'file') { return this.prepareOutputData(returnItems);
// For file downloads the files get attached to the existing items
return this.prepareOutputData(items);
} else {
// For all other ones does the output items get replaced
return this.prepareOutputData(returnItems);
}
} }
} }