From 5d2b09fddb62960f08cb85345f4bd3b56f07e7bd Mon Sep 17 00:00:00 2001
From: Alex Grozav <alex@grozav.com>
Date: Tue, 4 Jul 2023 15:42:44 +0300
Subject: [PATCH] fix: rename non-generic click events

---
 .../design-system/src/components/N8nActionBox/ActionBox.vue   | 2 +-
 .../src/components/N8nInfoAccordion/InfoAccordion.vue         | 2 +-
 packages/design-system/src/components/N8nTags/Tags.vue        | 2 +-
 .../src/components/CredentialEdit/CredentialSharing.ee.vue    | 4 ++--
 .../src/components/ExecutionsView/ExecutionsInfoAccordion.vue | 2 +-
 packages/editor-ui/src/components/FeatureComingSoon.vue       | 2 +-
 packages/editor-ui/src/components/TemplateDetails.vue         | 2 +-
 packages/editor-ui/src/components/TriggerPanel.vue            | 2 +-
 packages/editor-ui/src/components/WorkflowCard.vue            | 2 +-
 .../editor-ui/src/components/layouts/ResourcesListLayout.vue  | 2 +-
 packages/editor-ui/src/views/SettingsApiView.vue              | 4 ++--
 packages/editor-ui/src/views/SettingsAuditLogs.vue            | 2 +-
 packages/editor-ui/src/views/SettingsCommunityNodesView.vue   | 2 +-
 packages/editor-ui/src/views/SettingsLdapView.vue             | 2 +-
 packages/editor-ui/src/views/SettingsLogStreamingView.vue     | 4 ++--
 packages/editor-ui/src/views/SettingsSourceControl.vue        | 2 +-
 packages/editor-ui/src/views/SettingsSso.vue                  | 2 +-
 packages/editor-ui/src/views/SettingsUsageAndPlan.vue         | 2 +-
 packages/editor-ui/src/views/SettingsUsersView.vue            | 4 ++--
 packages/editor-ui/src/views/VariablesView.vue                | 4 ++--
 20 files changed, 25 insertions(+), 25 deletions(-)

diff --git a/packages/design-system/src/components/N8nActionBox/ActionBox.vue b/packages/design-system/src/components/N8nActionBox/ActionBox.vue
index a21f6e00d5..3995e08349 100644
--- a/packages/design-system/src/components/N8nActionBox/ActionBox.vue
+++ b/packages/design-system/src/components/N8nActionBox/ActionBox.vue
@@ -20,7 +20,7 @@
 			:label="buttonText"
 			:type="buttonType"
 			size="large"
-			@click="$emit('click', $event)"
+			@click="$emit('click:button', $event)"
 		/>
 		<n8n-callout
 			v-if="calloutText"
diff --git a/packages/design-system/src/components/N8nInfoAccordion/InfoAccordion.vue b/packages/design-system/src/components/N8nInfoAccordion/InfoAccordion.vue
index a01493a86a..ee3b292d5a 100644
--- a/packages/design-system/src/components/N8nInfoAccordion/InfoAccordion.vue
+++ b/packages/design-system/src/components/N8nInfoAccordion/InfoAccordion.vue
@@ -100,7 +100,7 @@ export default defineComponent({
 			this.expanded = !this.expanded;
 		},
 		onClick(e: MouseEvent) {
-			this.$emit('click', e);
+			this.$emit('click:body', e);
 		},
 		onTooltipClick(item: string, event: MouseEvent) {
 			this.$emit('tooltipClick', item, event);
diff --git a/packages/design-system/src/components/N8nTags/Tags.vue b/packages/design-system/src/components/N8nTags/Tags.vue
index 40e668f3ae..96012f44f0 100644
--- a/packages/design-system/src/components/N8nTags/Tags.vue
+++ b/packages/design-system/src/components/N8nTags/Tags.vue
@@ -4,7 +4,7 @@
 			v-for="tag in visibleTags"
 			:key="tag.id"
 			:text="tag.name"
-			@click="$emit('click', tag.id, $event)"
+			@click="$emit('click:tag', tag.id, $event)"
 		/>
 		<n8n-link
 			v-if="truncate && !showAll && hiddenTagsLength > 0"
diff --git a/packages/editor-ui/src/components/CredentialEdit/CredentialSharing.ee.vue b/packages/editor-ui/src/components/CredentialEdit/CredentialSharing.ee.vue
index c8638a01b3..0f91226224 100644
--- a/packages/editor-ui/src/components/CredentialEdit/CredentialSharing.ee.vue
+++ b/packages/editor-ui/src/components/CredentialEdit/CredentialSharing.ee.vue
@@ -17,7 +17,7 @@
 						uiStore.contextBasedTranslationKeys.credentials.sharing.unavailable.button,
 					)
 				"
-				@click="goToUpgrade"
+				@click:button="goToUpgrade"
 			/>
 		</div>
 		<div v-else-if="isDefaultUser">
@@ -27,7 +27,7 @@
 					$locale.baseText('credentialEdit.credentialSharing.isDefaultUser.description')
 				"
 				:buttonText="$locale.baseText('credentialEdit.credentialSharing.isDefaultUser.button')"
-				@click="goToUsersSettings"
+				@click:button="goToUsersSettings"
 			/>
 		</div>
 		<div v-else>
diff --git a/packages/editor-ui/src/components/ExecutionsView/ExecutionsInfoAccordion.vue b/packages/editor-ui/src/components/ExecutionsView/ExecutionsInfoAccordion.vue
index f0112edd1d..ade83195c3 100644
--- a/packages/editor-ui/src/components/ExecutionsView/ExecutionsInfoAccordion.vue
+++ b/packages/editor-ui/src/components/ExecutionsView/ExecutionsInfoAccordion.vue
@@ -5,7 +5,7 @@
 		:items="accordionItems"
 		:initiallyExpanded="shouldExpandAccordion"
 		:headerIcon="accordionIcon"
-		@click="onAccordionClick"
+		@click:body="onAccordionClick"
 		@tooltipClick="onItemTooltipClick"
 	>
 		<template #customContent>
diff --git a/packages/editor-ui/src/components/FeatureComingSoon.vue b/packages/editor-ui/src/components/FeatureComingSoon.vue
index c85c027edb..23e4153893 100644
--- a/packages/editor-ui/src/components/FeatureComingSoon.vue
+++ b/packages/editor-ui/src/components/FeatureComingSoon.vue
@@ -16,7 +16,7 @@
 				:buttonText="
 					$locale.baseText(featureInfo.actionBoxButtonLabel || 'fakeDoor.actionBox.button.label')
 				"
-				@click="openLinkPage"
+				@click:button="openLinkPage"
 			>
 				<template #heading>
 					<span v-html="$locale.baseText(featureInfo.actionBoxTitle)" />
diff --git a/packages/editor-ui/src/components/TemplateDetails.vue b/packages/editor-ui/src/components/TemplateDetails.vue
index 77c3881658..56bf07b1af 100644
--- a/packages/editor-ui/src/components/TemplateDetails.vue
+++ b/packages/editor-ui/src/components/TemplateDetails.vue
@@ -23,7 +23,7 @@
 			v-if="!loading && template?.categories.length > 0"
 			:title="$locale.baseText('template.details.categories')"
 		>
-			<n8n-tags :tags="template.categories" @click="redirectToCategory" />
+			<n8n-tags :tags="template.categories" @click:tag="redirectToCategory" />
 		</template-details-block>
 
 		<template-details-block v-if="!loading" :title="$locale.baseText('template.details.details')">
diff --git a/packages/editor-ui/src/components/TriggerPanel.vue b/packages/editor-ui/src/components/TriggerPanel.vue
index 52ce7e5726..13f256e9c6 100644
--- a/packages/editor-ui/src/components/TriggerPanel.vue
+++ b/packages/editor-ui/src/components/TriggerPanel.vue
@@ -95,7 +95,7 @@
 					:title="$locale.baseText('ndv.trigger.executionsHint.question')"
 					:description="executionsHelp"
 					:eventBus="executionsHelpEventBus"
-					@click="onLinkClick"
+					@click:body="onLinkClick"
 				></n8n-info-accordion>
 			</div>
 		</transition>
diff --git a/packages/editor-ui/src/components/WorkflowCard.vue b/packages/editor-ui/src/components/WorkflowCard.vue
index 2206bf308b..0d55ec437f 100644
--- a/packages/editor-ui/src/components/WorkflowCard.vue
+++ b/packages/editor-ui/src/components/WorkflowCard.vue
@@ -27,7 +27,7 @@
 						:tags="data.tags"
 						:truncateAt="3"
 						truncate
-						@click="onClickTag"
+						@click:tag="onClickTag"
 						@expand="onExpandTags"
 						data-test-id="workflow-card-tags"
 					/>
diff --git a/packages/editor-ui/src/components/layouts/ResourcesListLayout.vue b/packages/editor-ui/src/components/layouts/ResourcesListLayout.vue
index f5331b163a..9b7f9a9833 100644
--- a/packages/editor-ui/src/components/layouts/ResourcesListLayout.vue
+++ b/packages/editor-ui/src/components/layouts/ResourcesListLayout.vue
@@ -54,7 +54,7 @@
 						:description="$locale.baseText(`${resourceKey}.empty.description`)"
 						:buttonText="$locale.baseText(`${resourceKey}.empty.button`)"
 						buttonType="secondary"
-						@click="$emit('click:add', $event)"
+						@click:button="$emit('click:add', $event)"
 					/>
 				</slot>
 			</div>
diff --git a/packages/editor-ui/src/views/SettingsApiView.vue b/packages/editor-ui/src/views/SettingsApiView.vue
index f474deeab1..68760576c9 100644
--- a/packages/editor-ui/src/views/SettingsApiView.vue
+++ b/packages/editor-ui/src/views/SettingsApiView.vue
@@ -67,7 +67,7 @@
 			:heading="$locale.baseText('settings.api.trial.upgradePlan.title')"
 			:description="$locale.baseText('settings.api.trial.upgradePlan.description')"
 			:buttonText="$locale.baseText('settings.api.trial.upgradePlan.cta')"
-			@click="onUpgrade"
+			@click:button="onUpgrade"
 		/>
 		<n8n-action-box
 			v-else-if="mounted && !isLoadingCloudPlans"
@@ -77,7 +77,7 @@
 				)
 			"
 			:description="$locale.baseText('settings.api.create.description')"
-			@click="createApiKey"
+			@click:button="createApiKey"
 		/>
 	</div>
 </template>
diff --git a/packages/editor-ui/src/views/SettingsAuditLogs.vue b/packages/editor-ui/src/views/SettingsAuditLogs.vue
index e7d0caf90c..df31ad1df4 100644
--- a/packages/editor-ui/src/views/SettingsAuditLogs.vue
+++ b/packages/editor-ui/src/views/SettingsAuditLogs.vue
@@ -26,7 +26,7 @@ const goToUpgrade = () => {
 			:class="$style.actionBox"
 			:description="locale.baseText('settings.auditLogs.actionBox.description')"
 			:buttonText="locale.baseText('settings.auditLogs.actionBox.buttonText')"
-			@click="goToUpgrade"
+			@click:button="goToUpgrade"
 		>
 			<template #heading>
 				<span>{{ locale.baseText('settings.auditLogs.actionBox.title') }}</span>
diff --git a/packages/editor-ui/src/views/SettingsCommunityNodesView.vue b/packages/editor-ui/src/views/SettingsCommunityNodesView.vue
index ec94e1034a..6285ac25e4 100644
--- a/packages/editor-ui/src/views/SettingsCommunityNodesView.vue
+++ b/packages/editor-ui/src/views/SettingsCommunityNodesView.vue
@@ -38,7 +38,7 @@
 				:buttonText="getEmptyStateButtonText"
 				:calloutText="actionBoxConfig.calloutText"
 				:calloutTheme="actionBoxConfig.calloutTheme"
-				@click="onClickEmptyStateButton"
+				@click:button="onClickEmptyStateButton"
 			/>
 		</div>
 		<div :class="$style.cardsContainer" v-else>
diff --git a/packages/editor-ui/src/views/SettingsLdapView.vue b/packages/editor-ui/src/views/SettingsLdapView.vue
index d7fa777ba5..2cd5a3fc44 100644
--- a/packages/editor-ui/src/views/SettingsLdapView.vue
+++ b/packages/editor-ui/src/views/SettingsLdapView.vue
@@ -12,7 +12,7 @@
 		<n8n-action-box
 			:description="$locale.baseText('settings.ldap.disabled.description')"
 			:buttonText="$locale.baseText('settings.ldap.disabled.buttonText')"
-			@click="goToUpgrade"
+			@click:button="goToUpgrade"
 		>
 			<template #heading>
 				<span>{{ $locale.baseText('settings.ldap.disabled.title') }}</span>
diff --git a/packages/editor-ui/src/views/SettingsLogStreamingView.vue b/packages/editor-ui/src/views/SettingsLogStreamingView.vue
index 786743ce24..751d250c8f 100644
--- a/packages/editor-ui/src/views/SettingsLogStreamingView.vue
+++ b/packages/editor-ui/src/views/SettingsLogStreamingView.vue
@@ -44,7 +44,7 @@
 				<div data-test-id="action-box-licensed">
 					<n8n-action-box
 						:buttonText="$locale.baseText(`settings.log-streaming.add`)"
-						@click="addDestination"
+						@click:button="addDestination"
 					>
 						<template #heading>
 							<span v-html="$locale.baseText(`settings.log-streaming.addFirstTitle`)" />
@@ -63,7 +63,7 @@
 				<n8n-action-box
 					:description="$locale.baseText('settings.log-streaming.actionBox.description')"
 					:buttonText="$locale.baseText('settings.log-streaming.actionBox.button')"
-					@click="goToUpgrade"
+					@click:button="goToUpgrade"
 				>
 					<template #heading>
 						<span v-html="$locale.baseText('settings.log-streaming.actionBox.title')" />
diff --git a/packages/editor-ui/src/views/SettingsSourceControl.vue b/packages/editor-ui/src/views/SettingsSourceControl.vue
index 41d4ff2fc2..04524ce19c 100644
--- a/packages/editor-ui/src/views/SettingsSourceControl.vue
+++ b/packages/editor-ui/src/views/SettingsSourceControl.vue
@@ -375,7 +375,7 @@ const refreshBranches = async () => {
 			:class="$style.actionBox"
 			:description="locale.baseText('settings.sourceControl.actionBox.description')"
 			:buttonText="locale.baseText('settings.sourceControl.actionBox.buttonText')"
-			@click="goToUpgrade"
+			@click:button="goToUpgrade"
 		>
 			<template #heading>
 				<span>{{ locale.baseText('settings.sourceControl.actionBox.title') }}</span>
diff --git a/packages/editor-ui/src/views/SettingsSso.vue b/packages/editor-ui/src/views/SettingsSso.vue
index 7a7208b8f6..8a6ecb6eff 100644
--- a/packages/editor-ui/src/views/SettingsSso.vue
+++ b/packages/editor-ui/src/views/SettingsSso.vue
@@ -225,7 +225,7 @@ onMounted(async () => {
 			:class="$style.actionBox"
 			:description="i18n.baseText('settings.sso.actionBox.description')"
 			:buttonText="i18n.baseText('settings.sso.actionBox.buttonText')"
-			@click="goToUpgrade"
+			@click:button="goToUpgrade"
 		>
 			<template #heading>
 				<span>{{ i18n.baseText('settings.sso.actionBox.title') }}</span>
diff --git a/packages/editor-ui/src/views/SettingsUsageAndPlan.vue b/packages/editor-ui/src/views/SettingsUsageAndPlan.vue
index e53f232a09..08d191d7d5 100644
--- a/packages/editor-ui/src/views/SettingsUsageAndPlan.vue
+++ b/packages/editor-ui/src/views/SettingsUsageAndPlan.vue
@@ -134,7 +134,7 @@ const openPricingPage = () => {
 			:heading="locale.baseText('settings.usageAndPlan.desktop.title')"
 			:description="locale.baseText('settings.usageAndPlan.desktop.description')"
 			:buttonText="locale.baseText('settings.usageAndPlan.button.plans')"
-			@click="openPricingPage"
+			@click:button="openPricingPage"
 		/>
 		<div v-if="!usageStore.isDesktop && !usageStore.isLoading">
 			<n8n-heading :class="$style.title" size="large">
diff --git a/packages/editor-ui/src/views/SettingsUsersView.vue b/packages/editor-ui/src/views/SettingsUsersView.vue
index 64bbae3669..fe45627fb9 100644
--- a/packages/editor-ui/src/views/SettingsUsersView.vue
+++ b/packages/editor-ui/src/views/SettingsUsersView.vue
@@ -32,7 +32,7 @@
 				:buttonText="
 					$locale.baseText(uiStore.contextBasedTranslationKeys.users.settings.unavailable.button)
 				"
-				@click="goToUpgrade"
+				@click:button="goToUpgrade"
 			/>
 		</div>
 		<div v-else-if="usersStore.showUMSetupWarning" :class="$style.setupInfoContainer">
@@ -42,7 +42,7 @@
 				:description="`${
 					isSharingEnabled ? '' : $locale.baseText('settings.users.setupToInviteUsersInfo')
 				}`"
-				@click="redirectToSetup"
+				@click:button="redirectToSetup"
 			/>
 		</div>
 		<div :class="$style.usersContainer" v-else>
diff --git a/packages/editor-ui/src/views/VariablesView.vue b/packages/editor-ui/src/views/VariablesView.vue
index 39452a392c..324e3ca465 100644
--- a/packages/editor-ui/src/views/VariablesView.vue
+++ b/packages/editor-ui/src/views/VariablesView.vue
@@ -276,7 +276,7 @@ onBeforeUnmount(() => {
 				"
 				:buttonText="$locale.baseText(contextBasedTranslationKeys.variables.unavailable.button)"
 				buttonType="secondary"
-				@click="goToUpgrade"
+				@click:button="goToUpgrade"
 			/>
 		</template>
 		<template v-if="!isFeatureEnabled" #empty>
@@ -289,7 +289,7 @@ onBeforeUnmount(() => {
 				"
 				:buttonText="$locale.baseText(contextBasedTranslationKeys.variables.unavailable.button)"
 				buttonType="secondary"
-				@click="goToUpgrade"
+				@click:button="goToUpgrade"
 			/>
 		</template>
 		<template #default="{ data }">