mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2025-01-11 04:47:29 -08:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

⚡ Replace some fallback values to match the value type (#1421)

Browse source
This commit is contained in:
lublak 2021-03-08 18:45:35 +01:00 committed by GitHub
parent 5a214fb4aa
commit 5da61ef252
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
6 changed files with 8 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
packages/core/test/Helpers.ts
View file

@ -596,7 +596,7 @@ class NodeTypesClass implements INodeTypes {
let item: INodeExecutionData;
let keepOnlySet: boolean;
for (let itemIndex = 0; itemIndex < items.length; itemIndex++) {
keepOnlySet = this.getNodeParameter('keepOnlySet', itemIndex, []) as boolean;
keepOnlySet = this.getNodeParameter('keepOnlySet', itemIndex, false) as boolean;
item = items[itemIndex];
const options = this.getNodeParameter('options', itemIndex, {}) as IDataObject;

6
packages/nodes-base/nodes/Chargebee/Chargebee.node.ts
View file

@ -580,8 +580,8 @@ export class Chargebee implements INodeType {
requestMethod = 'POST';
const subscriptionId = this.getNodeParameter('subscriptionId', i, {}) as string;
body.end_of_term = this.getNodeParameter('endOfTerm', i, {}) as boolean;
const subscriptionId = this.getNodeParameter('subscriptionId', i, '') as string;
body.end_of_term = this.getNodeParameter('endOfTerm', i, false) as boolean;
endpoint = `subscriptions/${subscriptionId.trim()}/cancel`;
} else if (operation === 'delete') {
@ -591,7 +591,7 @@ export class Chargebee implements INodeType {
requestMethod = 'POST';
const subscriptionId = this.getNodeParameter('subscriptionId', i, {}) as string;
const subscriptionId = this.getNodeParameter('subscriptionId', i, '') as string;
endpoint = `subscriptions/${subscriptionId.trim()}/delete`;
} else {

2
packages/nodes-base/nodes/Cockpit/GenericFunctions.ts
View file

@ -50,7 +50,7 @@ export function createDataFromParameters(this: IExecuteFunctions | IExecuteSingl
if (dataFieldsAreJson) {
// Parameters are defined as JSON
return JSON.parse(this.getNodeParameter('dataFieldsJson', itemIndex, {}) as string);
return JSON.parse(this.getNodeParameter('dataFieldsJson', itemIndex, '') as string);
}
// Parameters are defined in UI

2
packages/nodes-base/nodes/GraphQL/GraphQL.node.ts
View file

@ -236,7 +236,7 @@ export class GraphQL implements INodeType {
requestOptions.body = {
query: gqlQuery,
variables: this.getNodeParameter('variables', itemIndex, {}) as object,
operationName: this.getNodeParameter('operationName', itemIndex, null) as string,
operationName: this.getNodeParameter('operationName', itemIndex) as string,
};
if (typeof requestOptions.body.variables === 'string') {
try {

2
packages/nodes-base/nodes/Set.node.ts
View file

@ -142,7 +142,7 @@ export class Set implements INodeType {
let item: INodeExecutionData;
let keepOnlySet: boolean;
for (let itemIndex = 0; itemIndex < items.length; itemIndex++) {
keepOnlySet = this.getNodeParameter('keepOnlySet', itemIndex, []) as boolean;
keepOnlySet = this.getNodeParameter('keepOnlySet', itemIndex, false) as boolean;
item = items[itemIndex];
const options = this.getNodeParameter('options', itemIndex, {}) as IDataObject;

2
packages/nodes-base/nodes/Slack/Slack.node.ts
View file

@ -741,7 +741,7 @@ export class Slack implements INodeType {
}
} else {
const attachmentsJson = this.getNodeParameter('attachmentsJson', i, []) as string;
const attachmentsJson = this.getNodeParameter('attachmentsJson', i, '') as string;
const blocksJson = this.getNodeParameter('blocksJson', i, []) as string;
if (attachmentsJson !== '' && validateJSON(attachmentsJson) === undefined) {
throw new Error('Attachments it is not a valid json');