Small improvements to Monday.com Node

This commit is contained in:
Jan Oberhauser 2020-03-28 00:34:39 +01:00
parent 65c33cedc0
commit 6042fd9d26
10 changed files with 46 additions and 43 deletions

View file

@ -3,8 +3,8 @@ import {
NodePropertyTypes, NodePropertyTypes,
} from 'n8n-workflow'; } from 'n8n-workflow';
export class MondayApi implements ICredentialType { export class MondayComApi implements ICredentialType {
name = 'mondayApi'; name = 'mondayComApi';
displayName = 'Monday.com API'; displayName = 'Monday.com API';
properties = [ properties = [
{ {

Binary file not shown.

Before

Width:  |  Height:  |  Size: 4.3 KiB

View file

@ -1,6 +1,6 @@
import { import {
INodeProperties INodeProperties
} from "n8n-workflow"; } from 'n8n-workflow';
export const boardColumnOperations = [ export const boardColumnOperations = [
{ {

View file

@ -1,6 +1,6 @@
import { import {
INodeProperties, INodeProperties,
} from "n8n-workflow"; } from 'n8n-workflow';
export const boardOperations = [ export const boardOperations = [
{ {
@ -155,8 +155,11 @@ export const boardFields = [
{ {
displayName: 'Board ID', displayName: 'Board ID',
name: 'boardId', name: 'boardId',
type: 'string', type: 'options',
default: '', default: '',
typeOptions: {
loadOptionsMethod: 'getBoards',
},
required: true, required: true,
displayOptions: { displayOptions: {
show: { show: {

View file

@ -1,6 +1,6 @@
import { import {
INodeProperties, INodeProperties,
} from "n8n-workflow"; } from 'n8n-workflow';
export const boardGroupOperations = [ export const boardGroupOperations = [
{ {

View file

@ -1,6 +1,6 @@
import { import {
INodeProperties, INodeProperties,
} from "n8n-workflow"; } from 'n8n-workflow';
export const boardItemOperations = [ export const boardItemOperations = [
{ {

View file

@ -17,9 +17,9 @@ import {
get, get,
} from 'lodash'; } from 'lodash';
export async function mondayApiRequest(this: IExecuteFunctions | IWebhookFunctions | IHookFunctions | ILoadOptionsFunctions, body: any = {}, option: IDataObject = {}): Promise<any> { // tslint:disable-line:no-any export async function mondayComApiRequest(this: IExecuteFunctions | IWebhookFunctions | IHookFunctions | ILoadOptionsFunctions, body: any = {}, option: IDataObject = {}): Promise<any> { // tslint:disable-line:no-any
const credentials = this.getCredentials('mondayApi'); const credentials = this.getCredentials('mondayComApi');
if (credentials === undefined) { if (credentials === undefined) {
throw new Error('No credentials got returned!'); throw new Error('No credentials got returned!');
@ -49,7 +49,7 @@ export async function mondayApiRequest(this: IExecuteFunctions | IWebhookFunctio
} }
} }
export async function mondayApiRequestAllItems(this: IHookFunctions | IExecuteFunctions | ILoadOptionsFunctions, propertyName: string, body: any = {}): Promise<any> { // tslint:disable-line:no-any export async function mondayComApiRequestAllItems(this: IHookFunctions | IExecuteFunctions | ILoadOptionsFunctions, propertyName: string, body: any = {}): Promise<any> { // tslint:disable-line:no-any
const returnData: IDataObject[] = []; const returnData: IDataObject[] = [];
@ -58,7 +58,7 @@ export async function mondayApiRequestAllItems(this: IHookFunctions | IExecuteFu
body.variables.page = 1; body.variables.page = 1;
do { do {
responseData = await mondayApiRequest.call(this, body); responseData = await mondayComApiRequest.call(this, body);
returnData.push.apply(returnData, get(responseData, propertyName)); returnData.push.apply(returnData, get(responseData, propertyName));
body.variables.page++; body.variables.page++;
} while ( } while (

View file

@ -5,15 +5,15 @@ import {
import { import {
IDataObject, IDataObject,
ILoadOptionsFunctions, ILoadOptionsFunctions,
INodeTypeDescription,
INodeExecutionData, INodeExecutionData,
INodeType,
INodePropertyOptions, INodePropertyOptions,
INodeType,
INodeTypeDescription,
} from 'n8n-workflow'; } from 'n8n-workflow';
import { import {
mondayApiRequest, mondayComApiRequest,
mondayApiRequestAllItems, mondayComApiRequestAllItems,
} from './GenericFunctions'; } from './GenericFunctions';
import { import {
@ -45,24 +45,24 @@ interface IGraphqlBody {
variables: IDataObject; variables: IDataObject;
} }
export class Monday implements INodeType { export class MondayCom implements INodeType {
description: INodeTypeDescription = { description: INodeTypeDescription = {
displayName: 'Monday.com', displayName: 'Monday.com',
name: 'monday.com', name: 'mondayCom',
icon: 'file:monday.png', icon: 'file:mondayCom.png',
group: ['output'], group: ['output'],
version: 1, version: 1,
subtitle: '={{$parameter["operation"] + ": " + $parameter["resource"]}}', subtitle: '={{$parameter["operation"] + ": " + $parameter["resource"]}}',
description: 'Consume Monday.com API', description: 'Consume Monday.com API',
defaults: { defaults: {
name: 'Monday.com', name: 'Monday.com',
color: '#000000', color: '#4353ff',
}, },
inputs: ['main'], inputs: ['main'],
outputs: ['main'], outputs: ['main'],
credentials: [ credentials: [
{ {
name: 'mondayApi', name: 'mondayComApi',
required: true, required: true,
}, },
], ],
@ -126,7 +126,7 @@ export class Monday implements INodeType {
page: 1, page: 1,
}, },
}; };
const boards = await mondayApiRequestAllItems.call(this, 'data.boards', body); const boards = await mondayComApiRequestAllItems.call(this, 'data.boards', body);
for (const board of boards) { for (const board of boards) {
const boardName = board.name; const boardName = board.name;
const boardId = board.id; const boardId = board.id;
@ -159,7 +159,7 @@ export class Monday implements INodeType {
boardId, boardId,
}, },
}; };
const { data } = await mondayApiRequest.call(this, body); const { data } = await mondayComApiRequest.call(this, body);
const columns = data.boards[0].columns; const columns = data.boards[0].columns;
for (const column of columns) { for (const column of columns) {
const columnName = column.title; const columnName = column.title;
@ -190,7 +190,7 @@ export class Monday implements INodeType {
boardId, boardId,
}, },
}; };
const { data } = await mondayApiRequest.call(this, body); const { data } = await mondayComApiRequest.call(this, body);
const groups = data.boards[0].groups; const groups = data.boards[0].groups;
for (const group of groups) { for (const group of groups) {
const groupName = group.title; const groupName = group.title;
@ -230,7 +230,7 @@ export class Monday implements INodeType {
}, },
}; };
responseData = await mondayApiRequest.call(this, body); responseData = await mondayComApiRequest.call(this, body);
responseData = responseData.data.archive_board; responseData = responseData.data.archive_board;
} }
if (operation === 'create') { if (operation === 'create') {
@ -255,7 +255,7 @@ export class Monday implements INodeType {
body.variables.templateId = additionalFields.templateId as number; body.variables.templateId = additionalFields.templateId as number;
} }
responseData = await mondayApiRequest.call(this, body); responseData = await mondayComApiRequest.call(this, body);
responseData = responseData.data.create_board; responseData = responseData.data.create_board;
} }
if (operation === 'get') { if (operation === 'get') {
@ -281,7 +281,7 @@ export class Monday implements INodeType {
}, },
}; };
responseData = await mondayApiRequest.call(this, body); responseData = await mondayComApiRequest.call(this, body);
responseData = responseData.data.boards; responseData = responseData.data.boards;
} }
if (operation === 'getAll') { if (operation === 'getAll') {
@ -308,10 +308,10 @@ export class Monday implements INodeType {
}; };
if (returnAll === true) { if (returnAll === true) {
responseData = await mondayApiRequestAllItems.call(this, 'data.boards', body); responseData = await mondayComApiRequestAllItems.call(this, 'data.boards', body);
} else { } else {
body.variables.limit = this.getNodeParameter('limit', i) as number, body.variables.limit = this.getNodeParameter('limit', i) as number,
responseData = await mondayApiRequest.call(this, body); responseData = await mondayComApiRequest.call(this, body);
responseData = responseData.data.boards; responseData = responseData.data.boards;
} }
} }
@ -346,7 +346,7 @@ export class Monday implements INodeType {
body.variables.defaults = JSON.stringify(JSON.parse(additionalFields.defaults as string)); body.variables.defaults = JSON.stringify(JSON.parse(additionalFields.defaults as string));
} }
responseData = await mondayApiRequest.call(this, body); responseData = await mondayComApiRequest.call(this, body);
responseData = responseData.data.create_column; responseData = responseData.data.create_column;
} }
if (operation === 'getAll') { if (operation === 'getAll') {
@ -371,7 +371,7 @@ export class Monday implements INodeType {
}, },
}; };
responseData = await mondayApiRequest.call(this, body); responseData = await mondayComApiRequest.call(this, body);
responseData = responseData.data.boards[0].columns; responseData = responseData.data.boards[0].columns;
} }
} }
@ -393,7 +393,7 @@ export class Monday implements INodeType {
}, },
}; };
responseData = await mondayApiRequest.call(this, body); responseData = await mondayComApiRequest.call(this, body);
responseData = responseData.data.create_group; responseData = responseData.data.create_group;
} }
if (operation === 'delete') { if (operation === 'delete') {
@ -413,7 +413,7 @@ export class Monday implements INodeType {
}, },
}; };
responseData = await mondayApiRequest.call(this, body); responseData = await mondayComApiRequest.call(this, body);
responseData = responseData.data.delete_group; responseData = responseData.data.delete_group;
} }
if (operation === 'getAll') { if (operation === 'getAll') {
@ -438,7 +438,7 @@ export class Monday implements INodeType {
}, },
}; };
responseData = await mondayApiRequest.call(this, body); responseData = await mondayComApiRequest.call(this, body);
responseData = responseData.data.boards[0].groups; responseData = responseData.data.boards[0].groups;
} }
} }
@ -472,7 +472,7 @@ export class Monday implements INodeType {
body.variables.columnValues = JSON.stringify(JSON.parse(additionalFields.columnValues as string)); body.variables.columnValues = JSON.stringify(JSON.parse(additionalFields.columnValues as string));
} }
responseData = await mondayApiRequest.call(this, body); responseData = await mondayComApiRequest.call(this, body);
responseData = responseData.data.create_item; responseData = responseData.data.create_item;
} }
if (operation === 'delete') { if (operation === 'delete') {
@ -489,7 +489,7 @@ export class Monday implements INodeType {
itemId, itemId,
}, },
}; };
responseData = await mondayApiRequest.call(this, body); responseData = await mondayComApiRequest.call(this, body);
responseData = responseData.data.delete_item; responseData = responseData.data.delete_item;
} }
if (operation === 'get') { if (operation === 'get') {
@ -517,7 +517,7 @@ export class Monday implements INodeType {
itemId: itemIds, itemId: itemIds,
}, },
}; };
responseData = await mondayApiRequest.call(this, body); responseData = await mondayComApiRequest.call(this, body);
responseData = responseData.data.items; responseData = responseData.data.items;
} }
if (operation === 'getAll') { if (operation === 'getAll') {
@ -555,10 +555,10 @@ export class Monday implements INodeType {
}; };
if (returnAll) { if (returnAll) {
responseData = await mondayApiRequestAllItems.call(this, 'data.boards[0].groups[0].items', body); responseData = await mondayComApiRequestAllItems.call(this, 'data.boards[0].groups[0].items', body);
} else { } else {
body.variables.limit = this.getNodeParameter('limit', i) as number; body.variables.limit = this.getNodeParameter('limit', i) as number;
responseData = await mondayApiRequest.call(this, body); responseData = await mondayComApiRequest.call(this, body);
responseData = responseData.data.boards[0].groups[0].items; responseData = responseData.data.boards[0].groups[0].items;
} }
@ -598,10 +598,10 @@ export class Monday implements INodeType {
}; };
if (returnAll) { if (returnAll) {
responseData = await mondayApiRequestAllItems.call(this, 'data.items_by_column_values', body); responseData = await mondayComApiRequestAllItems.call(this, 'data.items_by_column_values', body);
} else { } else {
body.variables.limit = this.getNodeParameter('limit', i) as number; body.variables.limit = this.getNodeParameter('limit', i) as number;
responseData = await mondayApiRequest.call(this, body); responseData = await mondayComApiRequest.call(this, body);
responseData = responseData.data.items_by_column_values; responseData = responseData.data.items_by_column_values;
} }
} }

Binary file not shown.

After

Width:  |  Height:  |  Size: 1.4 KiB

View file

@ -75,7 +75,7 @@
"dist/credentials/MattermostApi.credentials.js", "dist/credentials/MattermostApi.credentials.js",
"dist/credentials/MauticApi.credentials.js", "dist/credentials/MauticApi.credentials.js",
"dist/credentials/MoceanApi.credentials.js", "dist/credentials/MoceanApi.credentials.js",
"dist/credentials/MondayApi.credentials.js", "dist/credentials/MondayComApi.credentials.js",
"dist/credentials/MongoDb.credentials.js", "dist/credentials/MongoDb.credentials.js",
"dist/credentials/Msg91Api.credentials.js", "dist/credentials/Msg91Api.credentials.js",
"dist/credentials/MySql.credentials.js", "dist/credentials/MySql.credentials.js",
@ -186,7 +186,7 @@
"dist/nodes/Mautic/MauticTrigger.node.js", "dist/nodes/Mautic/MauticTrigger.node.js",
"dist/nodes/Merge.node.js", "dist/nodes/Merge.node.js",
"dist/nodes/Mocean/Mocean.node.js", "dist/nodes/Mocean/Mocean.node.js",
"dist/nodes/Monday/Monday.node.js", "dist/nodes/MondayCom/MondayCom.node.js",
"dist/nodes/MongoDb/MongoDb.node.js", "dist/nodes/MongoDb/MongoDb.node.js",
"dist/nodes/MoveBinaryData.node.js", "dist/nodes/MoveBinaryData.node.js",
"dist/nodes/Msg91/Msg91.node.js", "dist/nodes/Msg91/Msg91.node.js",