refactor(core): Ensure getSharedWorkflowIds returns string[] instead of number[] (#4971)

* 🔨 - getSharedWorkflowIds returns string[]

* 🔨 - update the sharedWorkflow function in public api

* 🔨 - update existing code to handle new data type

* simplify code

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>

packages/cli/src/PublicApi/v1/handlers/executions/executions.service.ts

@@ -123,7 +123,7 @@ export async function getExecutionsCount(data: {
 
 export async function getExecutionInWorkflows(
 	id: number,
-	workflows: number[],
+	workflows: string[],
 	includeData?: boolean,
 ): Promise<IExecutionResponseApi | undefined> {
 	const execution = await Db.collections.Execution.findOne({

packages/cli/src/PublicApi/v1/handlers/workflows/workflows.service.ts

@@ -15,12 +15,12 @@ function insertIf(condition: boolean, elements: string[]): string[] {
 	return condition ? elements : [];
 }
 
-export async function getSharedWorkflowIds(user: User): Promise<number[]> {
+export async function getSharedWorkflowIds(user: User): Promise<string[]> {
 	const sharedWorkflows = await Db.collections.SharedWorkflow.find({
 		where: { user },
 	});
 
-	return sharedWorkflows.map((workflow) => workflow.workflowId);
+	return sharedWorkflows.map(({ workflowId }) => workflowId.toString());
 }
 
 export async function getSharedWorkflow(

packages/cli/src/Server.ts

@@ -1345,9 +1345,7 @@ class App {
 
 					const filter = req.query.filter ? jsonParse<any>(req.query.filter) : {};
 
-					const sharedWorkflowIds = await getSharedWorkflowIds(req.user).then((ids) =>
+					const sharedWorkflowIds = await getSharedWorkflowIds(req.user);
-						ids.map((id) => id.toString()),
-					);
 
 					for (const data of executingWorkflows) {
 						if (

packages/cli/src/WorkflowHelpers.ts

@@ -405,13 +405,13 @@ export async function replaceInvalidCredentials(workflow: WorkflowEntity): Promi
  * Get the IDs of the workflows that have been shared with the user.
  * Returns all IDs if user is global owner (see `whereClause`)
  */
-export async function getSharedWorkflowIds(user: User, roles?: string[]): Promise<number[]> {
+export async function getSharedWorkflowIds(user: User, roles?: string[]): Promise<string[]> {
 	const sharedWorkflows = await Db.collections.SharedWorkflow.find({
 		relations: ['workflow', 'role'],
 		where: whereClause({ user, entityType: 'workflow', roles }),
 	});
 
-	return sharedWorkflows.map(({ workflow }) => workflow.id);
+	return sharedWorkflows.map(({ workflowId }) => workflowId.toString());
 }
 
 /**

packages/cli/src/executions/executions.service.ee.ts

@@ -6,7 +6,7 @@ export class EEExecutionsService extends ExecutionsService {
 	/**
 	 * Function to get the workflow Ids for a User regardless of role
 	 */
-	static async getWorkflowIdsForUser(user: User): Promise<number[]> {
+	static async getWorkflowIdsForUser(user: User): Promise<string[]> {
 		// Get all workflows
 		return getSharedWorkflowIds(user);
 	}

packages/cli/src/executions/executions.service.ts

@@ -55,7 +55,7 @@ export class ExecutionsService {
 	 * Function to get the workflow Ids for a User
 	 * Overridden in EE version to ignore roles
 	 */
-	static async getWorkflowIdsForUser(user: User): Promise<number[]> {
+	static async getWorkflowIdsForUser(user: User): Promise<string[]> {
 		// Get all workflows using owner role
 		return getSharedWorkflowIds(user, ['owner']);
 	}
@@ -160,9 +160,8 @@ export class ExecutionsService {
 		}
 
 		// safeguard against querying workflowIds not shared with the user
-		if (filter?.workflowId !== undefined) {
+		const workflowId = filter?.workflowId?.toString();
-			const workflowId = parseInt(filter.workflowId.toString());
+		if (workflowId !== undefined && !sharedWorkflowIds.includes(workflowId)) {
-			if (workflowId && !sharedWorkflowIds.includes(workflowId)) {
 			LoggerProxy.verbose(
 				`User ${req.user.id} attempted to query non-shared workflow ${workflowId}`,
 			);
@@ -172,7 +171,6 @@ export class ExecutionsService {
 				results: [],
 			};
 		}
-		}
 
 		const limit = req.query.limit
 			? parseInt(req.query.limit, 10)

packages/cli/src/workflows/workflows.services.ts

@@ -116,7 +116,7 @@ export class WorkflowsService {
 	}
 
 	// Warning: this function is overriden by EE to disregard role list.
-	static async getWorkflowIdsForUser(user: User, roles?: string[]) {
+	static async getWorkflowIdsForUser(user: User, roles?: string[]): Promise<string[]> {
 		return getSharedWorkflowIds(user, roles);
 	}
 
@@ -152,13 +152,11 @@ export class WorkflowsService {
 		}
 
 		// safeguard against querying ids not shared with the user
-		if (filter?.id !== undefined) {
+		const workflowId = filter?.id?.toString();
-			const workflowId = parseInt(filter.id.toString());
+		if (workflowId !== undefined && !sharedWorkflowIds.includes(workflowId)) {
-			if (workflowId && !sharedWorkflowIds.includes(workflowId)) {
 			LoggerProxy.verbose(`User ${user.id} attempted to query non-shared workflow ${workflowId}`);
 			return [];
 		}
-		}
 
 		const fields: Array<keyof WorkflowEntity> = ['id', 'name', 'active', 'createdAt', 'updatedAt'];
 		const relations: string[] = [];