From 60d28fc761c5e94566694593c6dac5611ced2ab5 Mon Sep 17 00:00:00 2001 From: OlegIvaniv Date: Wed, 12 Apr 2023 14:13:42 +0200 Subject: [PATCH] ci: Prevent skipping of E2E fail job (no-changelog) (#5958) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * ci: Prevent skipping of E2E fail job (no-changelog) * Set `continue-on-error: true` for e2e-reusable and add fail job * Always run e2e checks * Update 1-workflows.cy.ts --------- Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ --- .github/workflows/e2e-tests-pr.yml | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/.github/workflows/e2e-tests-pr.yml b/.github/workflows/e2e-tests-pr.yml index 5efa0a1752..7071ea565e 100644 --- a/.github/workflows/e2e-tests-pr.yml +++ b/.github/workflows/e2e-tests-pr.yml @@ -37,9 +37,10 @@ jobs: runs-on: ubuntu-latest name: E2E [Electron/Node 16] - Checks needs: [run-e2e-tests] + if: always() steps: - name: E2E success comment - if: success() + if: needs.run-e2e-tests.result == 'success' uses: peter-evans/create-or-update-comment@v3 with: issue-number: ${{ github.event.pull_request.number }} @@ -48,10 +49,14 @@ jobs: token: ${{ secrets.GITHUB_TOKEN }} - name: E2E fail comment - if: failure() + if: needs.run-e2e-tests.result == 'failure' uses: peter-evans/create-or-update-comment@v3 with: issue-number: ${{ github.event.pull_request.number }} body: | :warning: Some Cypress E2E specs are failing, please fix them before merging token: ${{ secrets.GITHUB_TOKEN }} + + - name: Fail job if run-e2e-tests failed + if: needs.run-e2e-tests.result == 'failure' + run: exit 1