mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2024-09-20 14:57:31 -07:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

fix(core): Prevent object deletion request on no prefix match (#7366)

Browse source
This commit is contained in:
Iván Ovejero 2023-10-06 15:46:39 +02:00 committed by GitHub
parent 7b773cc5cc
commit 63e11e4be9
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 10 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
packages/core/src/ObjectStore/ObjectStore.service.ee.ts
View file

@ -149,6 +149,8 @@ export class ObjectStoreService {
async deleteMany(prefix: string) { async deleteMany(prefix: string) {
const objects = await this.list(prefix); const objects = await this.list(prefix);
if (objects.length === 0) return;
const innerXml = objects.map(({ key }) => `<Object><Key>${key}</Key></Object>`).join('\n'); const innerXml = objects.map(({ key }) => `<Object><Key>${key}</Key></Object>`).join('\n');
const body = ['<Delete>', innerXml, '</Delete>'].join('\n'); const body = ['<Delete>', innerXml, '</Delete>'].join('\n');

8
packages/core/test/ObjectStore.service.test.ts
View file

@ -248,6 +248,14 @@ describe('deleteMany()', () => {
); );
}); });
it('should not send a deletion request if no prefix match', async () => {
objectStoreService.list = jest.fn().mockResolvedValue([]);
const result = await objectStoreService.deleteMany('non-matching-prefix');
expect(result).toBeUndefined();
});
it('should throw an error on request failure', async () => { it('should throw an error on request failure', async () => {
mockAxios.request.mockRejectedValue(mockError); mockAxios.request.mockRejectedValue(mockError);