From 6461423a5ce39ac921b63009d60b1e5fa0519e95 Mon Sep 17 00:00:00 2001 From: Mutasem Aldmour <4711238+mutdmour@users.noreply.github.com> Date: Wed, 22 Sep 2021 09:23:37 +0200 Subject: [PATCH] :zap: Add wait node toasts (#2203) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * :zap: Generalize unique entity name generation * :zap: Standardize variable names * redo credentials * revert some changes, replace got with was * fix v-if order * fix v-if order * update linting * update gulpfile * update ssh display name * update height * update params * update info tip sizes * address design comments * update google button disabled * update icon size to 28px * update design issues * update info tab design * address design comments * update tab size * update run data spacing * address comments, update logo design * fix spacing issues * clean up store * fix create new bug * add loading state * rename prop * remove unused prop * fix select bug * remove label tag * update word break * build * address design comments * update font family of button * update menu opacity * update text * update title * address more comments * update oauth messages * add oauth validation * hide disabled state * update warning modal * show button on text input * clean up cred details * add validation errors * fix bug when deleting cred * Frontend hack to display test button * Created interfaces for testing and endpoint * Testing slack node credentials working * Adding test with node to endpoint for credential testing * Fixed linting and test detectability * Adding required for slack token * Added google sheets credential testing * update message * Adding suggestions by Ivan and Mutasem * Address comments * keep blurred when focused * update font weight of errors * add oauth banner * remove toast * Fixed code bug and added telegram credential testing * scroll to top on success * clean up duplication * Fixed telegram trigger node and added tests to typeform * refactor modal * add more validation support * refactor info tab * scroll to bottom on save, handle cred saving * refactor save button * save cred on valid * save cred on valid * scroll to top if has error * add targets on input labels * delete credentails input * revert fe changes * update validation logic * clean interface * test credentials * update banner design * show testing state * update x position * fix issues * fix focus issues * clean up validation behavior * make error relative * update banner component * update error spacing * don't close dialog * rename button * update how banners behave * if has unsaved changes first * move confirm message * add success banner * update time state * disable transitions * test on open * clean up banner behavior * update banner styling * capitalize * update error banner styling to handle long texts * avoid unnessary content jostling * add loading label * show validation warnings when opening modal * retest cred if not all props req * update scroll to auto * add error warning * update color saturation * set overflow to auto * fix bug to get credentials when connected * round down to minutes * change tab name * update casing oauth * disable credential testing if it has expressions * label same as title * add more space between close and save * remove check on making any changes * hide close on confirm modals * don't accept clicks outside dialog * fix build issues * undo test changes * fix table scrollbar logs * rename modals * fix bug with same name * refactor modal * fix tslint issue * refactor name * update name behavior * update monospace font * remove comment * refactor inputs * refactor error handling * reduce spacing changes * fix doc url oauth1 oauth2 * build * add toast for waiting executions * hide infotip if no inputs * address most comments * rename file * fix menu alignment * gst * update types * update language * refactor toast behavior, add support for links clicking * allow closing workflow modal from notification * refactor how modals work * fix data display * update toast behavior * fix type issues * rename prop * update overflow behavior for settings * only expand used properties * fix edge bug * make scrollable prop, add margin to tags footer * remove max height from tag manager * rewrite message * fix notice word break * update property names * clear sticky notifications on run * build * refactor function out * use destruction Co-authored-by: Iván Ovejero Co-authored-by: Omar Ajoue --- packages/editor-ui/src/Interface.ts | 1 - .../CredentialEdit/CredentialEdit.vue | 3 +- .../src/components/CredentialsSelectModal.vue | 4 +- .../editor-ui/src/components/DataDisplay.vue | 1 + .../components/DuplicateWorkflowDialog.vue | 52 +++-- .../src/components/InlineNameEdit.vue | 6 +- .../editor-ui/src/components/MainSidebar.vue | 7 +- packages/editor-ui/src/components/Modal.vue | 204 ++++++++++-------- .../editor-ui/src/components/ModalDrawer.vue | 92 ++++++++ packages/editor-ui/src/components/Modals.vue | 15 +- .../components/TagsManager/TagsManager.vue | 3 +- .../editor-ui/src/components/UpdatesPanel.vue | 16 +- .../editor-ui/src/components/WorkflowOpen.vue | 3 +- .../src/components/WorkflowSettings.vue | 171 ++++++++------- .../src/components/mixins/helpers.ts | 11 + .../src/components/mixins/newVersions.ts | 7 +- .../src/components/mixins/pushConnection.ts | 33 ++- .../src/components/mixins/showMessage.ts | 66 +++++- .../src/components/mixins/workflowRun.ts | 4 + packages/editor-ui/src/constants.ts | 1 + packages/editor-ui/src/modules/ui.ts | 8 +- packages/editor-ui/src/store.ts | 12 +- packages/editor-ui/src/views/NodeView.vue | 14 +- packages/nodes-base/nodes/Wait.node.ts | 6 +- packages/nodes-base/nodes/Webhook.node.ts | 6 +- 25 files changed, 496 insertions(+), 250 deletions(-) create mode 100644 packages/editor-ui/src/components/ModalDrawer.vue create mode 100644 packages/editor-ui/src/components/mixins/helpers.ts diff --git a/packages/editor-ui/src/Interface.ts b/packages/editor-ui/src/Interface.ts index 8181647da4..10ecafc912 100644 --- a/packages/editor-ui/src/Interface.ts +++ b/packages/editor-ui/src/Interface.ts @@ -578,7 +578,6 @@ export interface IRootState { pushConnectionActive: boolean; saveDataErrorExecution: string; saveDataSuccessExecution: string; - saveManualExecutions: boolean; timezone: string; stateIsDirty: boolean; executionTimeout: number; diff --git a/packages/editor-ui/src/components/CredentialEdit/CredentialEdit.vue b/packages/editor-ui/src/components/CredentialEdit/CredentialEdit.vue index b4cf53aa60..a3b899f0d8 100644 --- a/packages/editor-ui/src/components/CredentialEdit/CredentialEdit.vue +++ b/packages/editor-ui/src/components/CredentialEdit/CredentialEdit.vue @@ -1,11 +1,12 @@