mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2025-02-21 02:56:40 -08:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

fix(editor): Properly set active project in new canvas (#12810)
Some checks are pending
Test Master / install-and-build (push) Waiting to run
Details
Test Master / Unit tests (18.x) (push) Blocked by required conditions
Details
Test Master / Unit tests (20.x) (push) Blocked by required conditions
Details
Test Master / Unit tests (22.4) (push) Blocked by required conditions
Details
Test Master / Lint (push) Blocked by required conditions
Details
Test Master / Notify Slack on failure (push) Blocked by required conditions
Details

Browse source
This commit is contained in:
Csaba Tuncsik 2025-01-27 12:32:03 +01:00 committed by GitHub
parent 663dfb48de
commit 648c6f9315
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 62 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

61
cypress/e2e/39-projects.cy.ts
View file

@ -1,3 +1,5 @@
import { setCredentialValues } from '../composables/modals/credential-modal';
import { clickCreateNewCredential, selectResourceLocatorItem } from '../composables/ndv';
import * as projects from '../composables/projects';
import {
INSTANCE_ADMIN,
@ -534,6 +536,65 @@ describe('Projects', { disableAutoLogin: true }, () => {
workflowPage.getters.canvasNodeByName(NOTION_NODE_NAME).should('be.visible').dblclick();
ndv.getters.credentialInput().find('input').should('be.enabled');
});
it('should create sub-workflow and credential in the sub-workflow in the same project', () => {
cy.signinAsOwner();
cy.visit(workflowsPage.url);
projects.createProject('Dev');
projects.getProjectTabWorkflows().click();
workflowsPage.getters.newWorkflowButtonCard().click();
workflowPage.actions.addNodeToCanvas(MANUAL_TRIGGER_NODE_NAME);
workflowPage.actions.saveWorkflowOnButtonClick();
workflowPage.actions.addNodeToCanvas('Execute Workflow', true, true);
cy.window().then((win) => {
cy.stub(win, 'open').callsFake((url) => {
cy.visit(url);
});
});
selectResourceLocatorItem('workflowId', 0, 'Create a');
workflowPage.actions.addNodeToCanvas(NOTION_NODE_NAME, true, true);
clickCreateNewCredential();
setCredentialValues({
apiKey: 'abc123',
});
ndv.actions.close();
workflowPage.actions.saveWorkflowOnButtonClick();
projects.getMenuItems().last().click();
workflowsPage.getters.workflowCards().should('have.length', 2);
projects.getProjectTabCredentials().click();
credentialsPage.getters.credentialCards().should('have.length', 1);
});
it('should create credential from workflow in the correct project after editor page refresh', () => {
cy.signinAsOwner();
cy.visit(workflowsPage.url);
projects.createProject('Dev');
projects.getProjectTabWorkflows().click();
workflowsPage.getters.newWorkflowButtonCard().click();
workflowPage.actions.addNodeToCanvas(MANUAL_TRIGGER_NODE_NAME);
workflowPage.actions.saveWorkflowOnButtonClick();
cy.reload();
workflowPage.actions.addNodeToCanvas(NOTION_NODE_NAME, true, true);
clickCreateNewCredential();
setCredentialValues({
apiKey: 'abc123',
});
ndv.actions.close();
workflowPage.actions.saveWorkflowOnButtonClick();
projects.getMenuItems().last().click();
projects.getProjectTabCredentials().click();
credentialsPage.getters.credentialCards().should('have.length', 1);
});
});
it('should set and update project icon', () => {

4
packages/editor-ui/src/views/NodeView.v2.vue
View file

@ -396,9 +396,7 @@ async function initializeWorkspaceForExistingWorkflow(id: string) {
trackOpenWorkflowFromOnboardingTemplate();
}
await projectsStore.setProjectNavActiveIdByWorkflowHomeProject(
editableWorkflow.value.homeProject,
);
await projectsStore.setProjectNavActiveIdByWorkflowHomeProject(workflowData.homeProject);
} catch (error) {
toast.showError(error, i18n.baseText('openWorkflow.workflowNotFoundError'));