mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2025-03-05 20:50:17 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

refactor: Remove any appcues events (#8597)

Browse source
This commit is contained in:
Mutasem Aldmour 2024-02-09 15:15:59 +01:00 committed by GitHub
parent cd151f1ba9
commit 64b10d7f5c
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 3 additions and 33 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
packages/editor-ui/src/Interface.ts
View file

@ -105,9 +105,6 @@ declare global {
}; };
// eslint-disable-next-line @typescript-eslint/naming-convention // eslint-disable-next-line @typescript-eslint/naming-convention
Cypress: unknown; Cypress: unknown;
Appcues?: {
track(event: string, properties?: ITelemetryTrackProperties): void;
};
} }
} }

26
packages/editor-ui/src/plugins/__tests__/telemetry.test.ts
View file

@ -141,12 +141,12 @@ describe('telemetry', () => {
}); });
describe('track function', () => { describe('track function', () => {
it('should call Rudderstack track method with correct parameters and', () => { it('should call Rudderstack track method with correct parameters', () => {
const trackFunction = vi.spyOn(window.rudderanalytics, 'track'); const trackFunction = vi.spyOn(window.rudderanalytics, 'track');
const event = 'testEvent'; const event = 'testEvent';
const properties = { test: '1' }; const properties = { test: '1' };
const options = { withPostHog: false, withAppCues: false }; const options = { withPostHog: false };
telemetry.track(event, properties, options); telemetry.track(event, properties, options);
@ -156,27 +156,5 @@ describe('telemetry', () => {
version_cli: MOCK_VERSION_CLI, version_cli: MOCK_VERSION_CLI,
}); });
}); });
it('should call Rudderstack track method with correct parameters and withAppCues option set to true', () => {
window.Appcues = { track: () => {} };
const trackFunction = vi.spyOn(window.rudderanalytics, 'track');
const appCuesTrackFunction = vi.spyOn(window.Appcues, 'track');
const event = 'testEvent';
const properties = { test: '1' };
const options = { withPostHog: false, withAppCues: true };
telemetry.track(event, properties, options);
expect(trackFunction).toHaveBeenCalledTimes(1);
expect(trackFunction).toHaveBeenCalledWith(event, {
...properties,
version_cli: MOCK_VERSION_CLI,
});
expect(appCuesTrackFunction).toHaveBeenCalledWith(event, {
...properties,
version_cli: MOCK_VERSION_CLI,
});
});
}); });
}); });

6
packages/editor-ui/src/plugins/telemetry/index.ts
View file

@ -99,7 +99,7 @@ export class Telemetry {
track( track(
event: string, event: string,
properties?: ITelemetryTrackProperties, properties?: ITelemetryTrackProperties,
options: { withPostHog?: boolean; withAppCues?: boolean } = {}, options: { withPostHog?: boolean } = {},
) { ) {
if (!this.rudderStack) return; if (!this.rudderStack) return;
@ -113,10 +113,6 @@ export class Telemetry {
if (options.withPostHog) { if (options.withPostHog) {
usePostHog().capture(event, updatedProperties); usePostHog().capture(event, updatedProperties);
} }
if (options.withAppCues && window.Appcues) {
window.Appcues.track(event, updatedProperties);
}
} }
page(route: Route) { page(route: Route) {

1
packages/editor-ui/src/views/NodeView.vue
View file

@ -3579,7 +3579,6 @@ export default defineComponent({
}, },
{ {
withPostHog: true, withPostHog: true,
withAppCues: true,
}, },
); );
} }