From 64fffa05793cb3524a6bc96c55c12765bcca336a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Iv=C3=A1n=20Ovejero?= <ivov.src@gmail.com>
Date: Thu, 29 Sep 2022 12:47:07 +0200
Subject: [PATCH] fix(lint): Set `no-unused-vars` to `warn` (#4228)

* :shirt: Set `no-unused-vars` to `warn`

* :shirt: Fix lint issue in `master`

* :pencil2: Fix plugin name
---
 packages/@n8n_io/eslint-config/base.js | 11 +++++++++--
 packages/cli/src/ExternalHooks.ts      |  1 -
 2 files changed, 9 insertions(+), 3 deletions(-)

diff --git a/packages/@n8n_io/eslint-config/base.js b/packages/@n8n_io/eslint-config/base.js
index 47f0bdd3cd..8509a485be 100644
--- a/packages/@n8n_io/eslint-config/base.js
+++ b/packages/@n8n_io/eslint-config/base.js
@@ -1,7 +1,7 @@
 /**
  * @type {import('@types/eslint').ESLint.ConfigData}
  */
-const config = module.exports = {
+const config = (module.exports = {
 	parser: '@typescript-eslint/parser',
 	parserOptions: {
 		sourceType: 'module',
@@ -361,6 +361,13 @@ const config = module.exports = {
 		 */
 		'prefer-spread': 'error',
 
+		/**
+		 * https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/docs/rules/no-unused-vars.md
+		 *
+		 * Disabled because eslint-plugin-diff fails to catch it. TODO: Revisit.
+		 */
+		'@typescript-eslint/no-unused-vars': 'warn',
+
 		// ----------------------------------
 		//              import
 		// ----------------------------------
@@ -370,7 +377,7 @@ const config = module.exports = {
 		 */
 		'import/prefer-default-export': 'off',
 	},
-};
+});
 
 if ('ESLINT_PLUGIN_DIFF_COMMIT' in process.env) {
 	/**
diff --git a/packages/cli/src/ExternalHooks.ts b/packages/cli/src/ExternalHooks.ts
index 5077821053..d7a09957bc 100644
--- a/packages/cli/src/ExternalHooks.ts
+++ b/packages/cli/src/ExternalHooks.ts
@@ -2,7 +2,6 @@
 /* eslint-disable import/no-dynamic-require */
 /* eslint-disable no-restricted-syntax */
 // eslint-disable-next-line import/no-cycle
-import { LoggerProxy } from 'n8n-workflow';
 import { Db, IExternalHooksClass, IExternalHooksFileData, IExternalHooksFunctions } from '.';
 
 import config from '../config';