From 66c189ea00633dbc44331257e8fa32c7c483a615 Mon Sep 17 00:00:00 2001 From: Eugene Date: Mon, 11 Nov 2024 11:51:42 +0100 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Tomi Turtiainen <10324676+tomi@users.noreply.github.com> --- .../cli/src/evaluation/test-definitions.controller.ee.ts | 6 +++--- packages/cli/src/evaluation/test-definitions.service.ee.ts | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/cli/src/evaluation/test-definitions.controller.ee.ts b/packages/cli/src/evaluation/test-definitions.controller.ee.ts index 8e754497ec..970ccdda7a 100644 --- a/packages/cli/src/evaluation/test-definitions.controller.ee.ts +++ b/packages/cli/src/evaluation/test-definitions.controller.ee.ts @@ -10,7 +10,7 @@ import { TestDefinitionsRequest } from './test-definitions.types.ee'; @RestController('/evaluation/test-definitions') export class TestDefinitionsController { - constructor(private readonly testsService: TestDefinitionsService) {} + constructor(private readonly testDefinitionsService: TestDefinitionsService) {} @Get('/', { middlewares: listQueryMiddleware }) async getMany(req: TestDefinitionsRequest.GetMany) { @@ -29,7 +29,7 @@ export class TestDefinitionsController { const testDefinition = await this.testsService.findOne(Number(req.params.id), workflowIds); - if (!testDefinition) throw new NotFoundError('Test not found'); + if (!testDefinition) throw new NotFoundError('Test definition not found'); return testDefinition; } @@ -57,7 +57,7 @@ export class TestDefinitionsController { const workflowIds = await getSharedWorkflowIds(req.user, ['workflow:read']); - if (workflowIds.length === 0) throw new NotFoundError('Test not found'); + if (workflowIds.length === 0) throw new NotFoundError('Test definition not found'); await this.testsService.delete(Number(req.params.id), workflowIds); diff --git a/packages/cli/src/evaluation/test-definitions.service.ee.ts b/packages/cli/src/evaluation/test-definitions.service.ee.ts index f0e26d4493..631ea8f9bb 100644 --- a/packages/cli/src/evaluation/test-definitions.service.ee.ts +++ b/packages/cli/src/evaluation/test-definitions.service.ee.ts @@ -20,7 +20,7 @@ type TestDefinitionLike = Omit< @Service() export class TestDefinitionsService { constructor( - private testRepository: TestDefinitionRepository, + private testDefinitionRepository: TestDefinitionRepository, private annotationTagRepository: AnnotationTagRepository, ) {}