mirror of
https://github.com/n8n-io/n8n.git
synced 2024-11-09 22:24:05 -08:00
fix: Fix sending pin data twice causing payload too large errors (#9710)
This commit is contained in:
parent
e08b4337c9
commit
6c1a4c8ebf
|
@ -536,10 +536,13 @@ describe('Execution', () => {
|
|||
|
||||
cy.wait('@workflowRun').then((interception) => {
|
||||
expect(interception.request.body).not.to.have.property('runData').that.is.an('object');
|
||||
expect(interception.request.body).to.have.property('pinData').that.is.an('object');
|
||||
expect(interception.request.body).to.have.property('workflowData').that.is.an('object');
|
||||
expect(interception.request.body.workflowData)
|
||||
.to.have.property('pinData')
|
||||
.that.is.an('object');
|
||||
const expectedPinnedDataKeys = ['Webhook'];
|
||||
|
||||
const { pinData } = interception.request.body as Record<string, object>;
|
||||
const { pinData } = interception.request.body.workflowData as Record<string, object>;
|
||||
expect(Object.keys(pinData)).to.have.lengthOf(expectedPinnedDataKeys.length);
|
||||
expect(pinData).to.include.all.keys(expectedPinnedDataKeys);
|
||||
});
|
||||
|
@ -555,14 +558,18 @@ describe('Execution', () => {
|
|||
|
||||
cy.wait('@workflowRun').then((interception) => {
|
||||
expect(interception.request.body).to.have.property('runData').that.is.an('object');
|
||||
expect(interception.request.body).to.have.property('pinData').that.is.an('object');
|
||||
expect(interception.request.body).to.have.property('workflowData').that.is.an('object');
|
||||
expect(interception.request.body.workflowData)
|
||||
.to.have.property('pinData')
|
||||
.that.is.an('object');
|
||||
const expectedPinnedDataKeys = ['Webhook'];
|
||||
const expectedRunDataKeys = ['If', 'Webhook'];
|
||||
|
||||
const { pinData, runData } = interception.request.body as Record<string, object>;
|
||||
const { pinData } = interception.request.body.workflowData as Record<string, object>;
|
||||
expect(Object.keys(pinData)).to.have.lengthOf(expectedPinnedDataKeys.length);
|
||||
expect(pinData).to.include.all.keys(expectedPinnedDataKeys);
|
||||
|
||||
const { runData } = interception.request.body as Record<string, object>;
|
||||
expect(Object.keys(runData)).to.have.lengthOf(expectedRunDataKeys.length);
|
||||
expect(runData).to.include.all.keys(expectedRunDataKeys);
|
||||
});
|
||||
|
|
|
@ -1,13 +1,6 @@
|
|||
import type { IWorkflowDb } from '@/Interfaces';
|
||||
import type { AuthenticatedRequest, ListQuery } from '@/requests';
|
||||
import type {
|
||||
INode,
|
||||
IConnections,
|
||||
IWorkflowSettings,
|
||||
IRunData,
|
||||
IPinData,
|
||||
StartNodeData,
|
||||
} from 'n8n-workflow';
|
||||
import type { INode, IConnections, IWorkflowSettings, IRunData, StartNodeData } from 'n8n-workflow';
|
||||
|
||||
export declare namespace WorkflowRequest {
|
||||
type CreateUpdatePayload = Partial<{
|
||||
|
@ -26,7 +19,6 @@ export declare namespace WorkflowRequest {
|
|||
type ManualRunPayload = {
|
||||
workflowData: IWorkflowDb;
|
||||
runData: IRunData;
|
||||
pinData: IPinData;
|
||||
startNodes?: StartNodeData[];
|
||||
destinationNode?: string;
|
||||
};
|
||||
|
|
|
@ -92,16 +92,11 @@ export class WorkflowExecutionService {
|
|||
}
|
||||
|
||||
async executeManually(
|
||||
{
|
||||
workflowData,
|
||||
runData,
|
||||
pinData,
|
||||
startNodes,
|
||||
destinationNode,
|
||||
}: WorkflowRequest.ManualRunPayload,
|
||||
{ workflowData, runData, startNodes, destinationNode }: WorkflowRequest.ManualRunPayload,
|
||||
user: User,
|
||||
pushRef?: string,
|
||||
) {
|
||||
const pinData = workflowData.pinData;
|
||||
const pinnedTrigger = this.selectPinnedActivatorStarter(
|
||||
workflowData,
|
||||
startNodes?.map((nodeData) => nodeData.name),
|
||||
|
|
|
@ -200,7 +200,6 @@ export interface IStartRunData {
|
|||
startNodes?: StartNodeData[];
|
||||
destinationNode?: string;
|
||||
runData?: IRunData;
|
||||
pinData?: IPinData;
|
||||
}
|
||||
|
||||
export interface ITableData {
|
||||
|
|
|
@ -219,7 +219,6 @@ export function useRunWorkflow(useRunWorkflowOpts: { router: ReturnType<typeof u
|
|||
const startRunData: IStartRunData = {
|
||||
workflowData,
|
||||
runData: newRunData,
|
||||
pinData: workflowData.pinData,
|
||||
startNodes,
|
||||
};
|
||||
if ('destinationNode' in options) {
|
||||
|
|
Loading…
Reference in a new issue