mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2025-01-11 12:57:29 -08:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

🐛 Do not error if there is no data on Google Analytics + Sort

Browse source
This commit is contained in:
Jan Oberhauser 2021-06-25 15:38:32 +02:00
parent fe71c665fe
commit 6c7e1ec3c9
2 changed files with 13 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
packages/nodes-base/nodes/Google/Analytics/GenericFunctions.ts
View file

@ -70,6 +70,10 @@ export async function googleApiRequestAllItems(this: IExecuteFunctions | ILoadOp
export function simplify(responseData: any | [any]) { // tslint:disable-line:no-any
const response = [];
for (const { columnHeader: { dimensions }, data: { rows } } of responseData) {
if (rows === undefined) {
// Do not error if there is no data
continue;
}
for (const row of rows) {
const data: IDataObject = {};
if (dimensions) {

9
packages/nodes-base/nodes/Google/Analytics/GoogleAnalytics.node.ts
View file

@ -112,6 +112,15 @@ export class GoogleAnalytics implements INodeType {
});
}
}
returnData.sort((a, b) => {
const aName= a.name.toLowerCase();
const bName= b.name.toLowerCase();
if (aName < bName) { return -1; }
if (aName > bName) { return 1; }
return 0;
});
return returnData;
},
// Get all the views to display them to user so that he can