mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2024-12-24 04:04:06 -08:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

fix(core): Fix url in error handelling for the error Trigger (#5201)

Browse source 
* Add workflow id to url in error message

* fix mock message for manual execution

* Fix url missing 's'
This commit is contained in:
agobrech 2023-01-19 17:56:31 +01:00 committed by GitHub
parent 537816a336
commit 6e391755e4
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
packages/cli/src/WorkflowExecuteAdditionalData.ts
View file

@ -88,7 +88,9 @@ export function executeErrorWorkflow(
let pastExecutionUrl: string | undefined; let pastExecutionUrl: string | undefined;
if (executionId !== undefined) { if (executionId !== undefined) {
pastExecutionUrl = `${WebhookHelpers.getWebhookBaseUrl()}execution/${executionId}`; pastExecutionUrl = `${WebhookHelpers.getWebhookBaseUrl()}workflow/${
workflowData.id
}/executions/${executionId}`;
} }
if (fullRunData.data.resultData.error !== undefined) { if (fullRunData.data.resultData.error !== undefined) {

2
packages/nodes-base/nodes/ErrorTrigger/ErrorTrigger.node.ts
View file

@ -54,7 +54,7 @@ export class ErrorTrigger implements INodeType {
items[0].json = { items[0].json = {
execution: { execution: {
id, id,
url: `${urlParts.join('/')}/${id}`, url: `${urlParts.join('/')}/workflow/1/${id}`,
retryOf: '34', retryOf: '34',
error: { error: {
message: 'Example Error Message', message: 'Example Error Message',