mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2025-03-05 20:50:17 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix(HubSpot Node): Fix issue with contact lists not working (#5582)

Browse source
This commit is contained in:
Jon 2023-09-12 17:04:39 +01:00 committed by GitHub
parent 915cfa0f6a
commit 6e5a4f6a58
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 15 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
packages/nodes-base/credentials/HubspotOAuth2Api.credentials.ts
View file

@ -1,16 +1,17 @@
import type { ICredentialType, INodeProperties } from 'n8n-workflow'; import type { ICredentialType, INodeProperties } from 'n8n-workflow';
const scopes = [ const scopes = [
'crm.schemas.deals.read', 'crm.lists.write',
'crm.objects.owners.read',
'crm.objects.contacts.write',
'crm.objects.companies.write',
'crm.objects.companies.read',
'crm.objects.deals.read',
'crm.schemas.contacts.read',
'crm.objects.deals.write',
'crm.objects.contacts.read', 'crm.objects.contacts.read',
'crm.objects.contacts.write',
'crm.objects.companies.read',
'crm.objects.companies.write',
'crm.objects.deals.read',
'crm.objects.deals.write',
'crm.objects.owners.read',
'crm.schemas.companies.read', 'crm.schemas.companies.read',
'crm.schemas.contacts.read',
'crm.schemas.deals.read',
'forms', 'forms',
'tickets', 'tickets',
]; ];

2
packages/nodes-base/nodes/Hubspot/V2/ContactListDescription.ts
View file

@ -86,7 +86,7 @@ export const contactListFields: INodeProperties[] = [
default: '', default: '',
}, },
{ {
displayName: 'List to Add From', displayName: 'List to Add To',
name: 'listId', name: 'listId',
type: 'number', type: 'number',
required: true, required: true,

7
packages/nodes-base/nodes/Hubspot/V2/HubspotV2.node.ts
View file

@ -1152,7 +1152,6 @@ export class HubspotV2 implements INodeType {
`/contacts/v1/lists/${listId}/add`, `/contacts/v1/lists/${listId}/add`,
body, body,
); );
returnData.push.apply(returnData, responseData as INodeExecutionData[]);
} }
//https://legacydocs.hubspot.com/docs/methods/lists/remove_contact_from_list //https://legacydocs.hubspot.com/docs/methods/lists/remove_contact_from_list
if (operation === 'remove') { if (operation === 'remove') {
@ -1168,8 +1167,12 @@ export class HubspotV2 implements INodeType {
`/contacts/v1/lists/${listId}/remove`, `/contacts/v1/lists/${listId}/remove`,
body, body,
); );
returnData.push.apply(returnData, responseData as INodeExecutionData[]);
} }
const executionData = this.helpers.constructExecutionMetaData(
this.helpers.returnJsonArray(responseData as IDataObject[]),
{ itemData: { item: 0 } },
);
returnData.push(...executionData);
} catch (error) { } catch (error) {
if (this.continueOnFail()) { if (this.continueOnFail()) {
returnData.push({ json: { error: (error as JsonObject).message } }); returnData.push({ json: { error: (error as JsonObject).message } });