From 6ed9ef0b60dbc257b1ac6deceae5f3f7c0b593c4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Iv=C3=A1n=20Ovejero?= Date: Mon, 27 May 2024 16:52:17 +0200 Subject: [PATCH] refactor(core): Prevent reporting to Sentry IMAP server error (no-changelog) (#9515) --- .../workflow/src/errors/workflow-activation.error.ts | 9 ++++++++- .../test/errors/workflow-activation.error.test.ts | 4 ++-- 2 files changed, 10 insertions(+), 3 deletions(-) diff --git a/packages/workflow/src/errors/workflow-activation.error.ts b/packages/workflow/src/errors/workflow-activation.error.ts index b1816ba861..db24672775 100644 --- a/packages/workflow/src/errors/workflow-activation.error.ts +++ b/packages/workflow/src/errors/workflow-activation.error.ts @@ -41,7 +41,14 @@ export class WorkflowActivationError extends ExecutionBaseError { return; } - if (['ETIMEDOUT', 'ECONNREFUSED', 'EAUTH'].some((code) => this.message.includes(code))) { + if ( + [ + 'etimedout', // Node.js + 'econnrefused', // Node.js + 'eauth', // OAuth + 'temporary authentication failure', // IMAP server + ].some((str) => this.message.toLowerCase().includes(str)) + ) { this.level = 'warning'; return; } diff --git a/packages/workflow/test/errors/workflow-activation.error.test.ts b/packages/workflow/test/errors/workflow-activation.error.test.ts index 19aaca6de2..77c3b73a24 100644 --- a/packages/workflow/test/errors/workflow-activation.error.test.ts +++ b/packages/workflow/test/errors/workflow-activation.error.test.ts @@ -18,8 +18,8 @@ describe('WorkflowActivationError', () => { expect(secondError.level).toBe('error'); }); - test.each(['ETIMEDOUT', 'ECONNREFUSED', 'EAUTH'])( - 'should set `level` to `warning` for %s', + test.each(['ETIMEDOUT', 'ECONNREFUSED', 'EAUTH', 'Temporary authentication failure'])( + 'should set `level` to `warning` for `%s`', (code) => { const error = new WorkflowActivationError(code, { cause });