mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2025-03-05 20:50:17 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix(core): Setup webhook stopping endpoint after the CORS middleware (no-changelog) (#9454)

Browse source
This commit is contained in:
कारतोफ्फेलस्क्रिप्ट™ 2024-05-17 17:55:29 +02:00 committed by GitHub
parent 04dd4760e1
commit 6f2d83bffd
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 10 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
packages/cli/src/AbstractServer.ts
View file

@ -207,13 +207,6 @@ export abstract class AbstractServer {
// Register a handler // Register a handler
this.app.all(`/${this.endpointFormTest}/:path(*)`, webhookRequestHandler(testWebhooks)); this.app.all(`/${this.endpointFormTest}/:path(*)`, webhookRequestHandler(testWebhooks));
this.app.all(`/${this.endpointWebhookTest}/:path(*)`, webhookRequestHandler(testWebhooks)); this.app.all(`/${this.endpointWebhookTest}/:path(*)`, webhookRequestHandler(testWebhooks));
// Removes a test webhook
// TODO UM: check if this needs validation with user management.
this.app.delete(
`/${this.restEndpoint}/test-webhook/:id`,
send(async (req) => await testWebhooks.cancelWebhook(req.params.id)),
);
} }
// Block bots from scanning the application // Block bots from scanning the application
@ -230,6 +223,16 @@ export abstract class AbstractServer {
this.setupDevMiddlewares(); this.setupDevMiddlewares();
} }
if (this.testWebhooksEnabled) {
const testWebhooks = Container.get(TestWebhooks);
// Removes a test webhook
// TODO UM: check if this needs validation with user management.
this.app.delete(
`/${this.restEndpoint}/test-webhook/:id`,
send(async (req) => await testWebhooks.cancelWebhook(req.params.id)),
);
}
// Setup body parsing middleware after the webhook handlers are setup // Setup body parsing middleware after the webhook handlers are setup
this.app.use(bodyParser); this.app.use(bodyParser);