mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2024-11-13 16:14:07 -08:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

⚡ Clarify max iterations error message (#2129)

Browse source 
* ✏️ Add hint to max iterations error message

* 👕 Fix build
This commit is contained in:
Iván Ovejero 2021-08-29 13:58:20 +02:00 committed by GitHub
parent 96f3a6256d
commit 71dccbba5c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
packages/workflow/src/NodeHelpers.ts
View file

@ -307,7 +307,7 @@ export function displayParameter(nodeValues: INodeParameters, parameter: INodePr
} }
if (parameter.displayOptions.hide) { if (parameter.displayOptions.hide) {
// Any of the defined hide rules have to match to hide the paramter // Any of the defined hide rules have to match to hide the parameter
for (const propertyName of Object.keys(parameter.displayOptions.hide)) { for (const propertyName of Object.keys(parameter.displayOptions.hide)) {
if (propertyName.charAt(0) === '/') { if (propertyName.charAt(0) === '/') {
// Get the value from the root of the node // Get the value from the root of the node
@ -439,14 +439,14 @@ export function getParamterDependencies(nodePropertiesArray: INodeProperties[]):
/** /**
* Returns in which order the parameters should be resolved * Returns in which order the parameters should be resolved
* to have the paramters available they are depent on * to have the parameters available they depend on
* *
* @export * @export
* @param {INodeProperties[]} nodePropertiesArray * @param {INodeProperties[]} nodePropertiesArray
* @param {IParameterDependencies} parameterDependencies * @param {IParameterDependencies} parameterDependencies
* @returns {number[]} * @returns {number[]}
*/ */
export function getParamterResolveOrder(nodePropertiesArray: INodeProperties[], parameterDependencies: IParameterDependencies): number[] { export function getParameterResolveOrder(nodePropertiesArray: INodeProperties[], parameterDependencies: IParameterDependencies): number[] {
const executionOrder: number[] = []; const executionOrder: number[] = [];
const indexToResolve = Array.from({ length: nodePropertiesArray.length }, (v, k) => k); const indexToResolve = Array.from({ length: nodePropertiesArray.length }, (v, k) => k);
const resolvedParamters: string[] = []; const resolvedParamters: string[] = [];
@ -495,7 +495,7 @@ export function getParamterResolveOrder(nodePropertiesArray: INodeProperties[],
} }
if (itterations > lastIndexReduction + nodePropertiesArray.length) { if (itterations > lastIndexReduction + nodePropertiesArray.length) {
throw new Error('Could not resolve parameter depenencies. Max itterations got reached!'); throw new Error('Could not resolve parameter depenencies. Max iterations reached! Hint: If `displayOptions` are specified in any child parameter of a parent `collection` or `fixedCollection`, remove the `displayOptions` from the child parameter.');
} }
lastIndexLength = indexToResolve.length; lastIndexLength = indexToResolve.length;
} }
@ -548,7 +548,7 @@ export function getNodeParameters(nodePropertiesArray: INodeProperties[], nodeVa
nodeValuesRoot = nodeValuesRoot || nodeValuesDisplayCheck; nodeValuesRoot = nodeValuesRoot || nodeValuesDisplayCheck;
// Go through the parameters in order of their dependencies // Go through the parameters in order of their dependencies
const parameterItterationOrderIndex = getParamterResolveOrder(nodePropertiesArray, parameterDependencies); const parameterItterationOrderIndex = getParameterResolveOrder(nodePropertiesArray, parameterDependencies);
for (const parameterIndex of parameterItterationOrderIndex) { for (const parameterIndex of parameterItterationOrderIndex) {
const nodeProperties = nodePropertiesArray[parameterIndex]; const nodeProperties = nodePropertiesArray[parameterIndex];