🐛 Fix bug with Typeform OAuth2 flow (#1402)

This commit is contained in:
Ricardo Espinoza 2021-02-04 03:58:33 -05:00 committed by GitHub
parent 049bf6bee8
commit 7226b5071e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 16 additions and 7 deletions

View file

@ -9,7 +9,6 @@ const scopes = [
'forms:read',
];
export class TypeformOAuth2Api implements ICredentialType {
name = 'typeformOAuth2Api';
extends = [
@ -36,7 +35,7 @@ export class TypeformOAuth2Api implements ICredentialType {
displayName: 'Scope',
name: 'scope',
type: 'hidden' as NodePropertyTypes,
default: scopes.join(','),
default: scopes.join(' '),
},
{
displayName: 'Auth URI Query Parameters',

View file

@ -8,9 +8,13 @@ import {
INodePropertyOptions,
} from 'n8n-workflow';
import { OptionsWithUri } from 'request';
import { IDataObject } from 'n8n-workflow';
import {
OptionsWithUri,
} from 'request';
import {
IDataObject,
} from 'n8n-workflow';
// Interface in Typeform
export interface ITypeformDefinition {

View file

@ -22,7 +22,7 @@ export class TypeformTrigger implements INodeType {
description: INodeTypeDescription = {
displayName: 'Typeform Trigger',
name: 'typeformTrigger',
icon: 'file:typeform.png',
icon: 'file:typeform.svg',
group: ['trigger'],
version: 1,
subtitle: '=Form ID: {{$parameter["formId"]}}',
@ -133,10 +133,10 @@ export class TypeformTrigger implements INodeType {
for (const item of items) {
if (item.form_id === formId
&& item.url === webhookUrl) {
&& item.url === webhookUrl) {
webhookData.webhookId = item.tag;
return true;
}
}
}
return false;

Binary file not shown.

Before

Width:  |  Height:  |  Size: 988 B

View file

@ -0,0 +1,6 @@
<?xml version="1.0" encoding="UTF-8"?>
<svg width="256px" height="257px" viewBox="0 0 256 257" version="1.1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" preserveAspectRatio="xMidYMid">
<g>
<path d="M121.239531,0.47435412 C154.258847,-2.24419986 177.973534,6.51949224 203.490026,32.0209539 C231.03887,59.5533708 249.354214,95.2328648 254.290235,133.239251 C259.781839,175.505244 252.228399,207.045826 228.963591,230.137302 C206.717472,252.217693 174.224091,259.500956 130.817584,255.872056 L130.817584,255.872056 L129.020628,255.714401 C92.0580678,252.31591 65.9142731,240.197353 40.5830264,214.542641 C13.525519,187.139558 -0.732370213,156.026391 0.0289819699,123.37039 C0.401368488,107.383336 4.93009017,93.7578927 13.6639513,80.3889177 C19.3897229,71.6244438 25.2046788,64.7874057 37.3681164,52.2487147 L37.3681164,52.2487147 L41.4275324,48.0907013 L45.9022443,43.5551431 C74.7290193,14.5793771 93.7072016,2.74118195 121.239531,0.47435412 Z M201.527922,33.9842216 C176.58625,9.05724142 153.671595,0.589198793 121.467288,3.24065127 C94.3271196,5.47519117 75.6884654,17.3319772 46.5188613,46.8760997 L46.5188613,46.8760997 L44.4086816,49.0171264 C30.1966379,63.4648858 23.5365117,70.8518409 17.66965,79.3947543 L17.66965,79.3947543 L16.8159631,80.6541424 L15.9876804,81.9069942 C7.52700788,94.8577977 3.16375473,107.9854 2.80388584,123.435056 C2.06141566,155.281167 15.9979199,185.693018 42.5581255,212.592447 C67.82505,238.182016 93.7827344,249.991613 131.048788,253.106044 L131.048788,253.106044 L132.897415,253.254431 C174.642425,256.464747 205.76515,249.252143 227.008257,228.167291 C249.578581,205.765126 256.927442,175.078792 251.537704,133.596809 C246.682834,96.2152658 228.654224,61.0943485 201.527922,33.9842216 Z M166.984321,93.3903087 L166.984321,106.949394 L138.186877,106.949394 L138.186877,184.662246 L123.842281,184.662246 L123.842281,106.949394 L95.044837,106.949394 L95.044837,93.3903087 L166.984321,93.3903087 Z" fill="#262627" fill-rule="nonzero"></path>
</g>
</svg>

After

Width:  |  Height:  |  Size: 2 KiB