mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2024-11-14 16:44:07 -08:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

self review

Browse source
This commit is contained in:
Charlie Kolb 2024-11-13 09:40:35 +01:00
parent a1cf28dce9
commit 738aee4d46
No known key found for this signature in database
4 changed files with 11 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
packages/editor-ui/src/stores/workflows.store.ts
View file

@ -1112,7 +1112,6 @@ export const useWorkflowsStore = defineStore(STORES.WORKFLOWS, () => {
nodeData.type = getCredentialOnlyNodeTypeName(nodeData.extendsCredential); nodeData.type = getCredentialOnlyNodeTypeName(nodeData.extendsCredential);
} }
// here?
workflow.value.nodes.push(nodeData); workflow.value.nodes.push(nodeData);
// Init node metadata // Init node metadata
if (!nodeMetadata.value[nodeData.name]) { if (!nodeMetadata.value[nodeData.name]) {

11
packages/editor-ui/src/utils/connectionNodeUtils.test.ts
View file

@ -1,4 +1,3 @@
import { useWorkflowsStore } from '@/stores/workflows.store';
import { AGENT_NODE_TYPE, CHAT_TRIGGER_NODE_TYPE, MANUAL_TRIGGER_NODE_TYPE } from '@/constants'; import { AGENT_NODE_TYPE, CHAT_TRIGGER_NODE_TYPE, MANUAL_TRIGGER_NODE_TYPE } from '@/constants';
import { adjustNewNodes } from '@/utils/connectionNodeUtils'; import { adjustNewNodes } from '@/utils/connectionNodeUtils';
import { createPinia, setActivePinia } from 'pinia'; import { createPinia, setActivePinia } from 'pinia';
@ -24,7 +23,9 @@ describe('adjustNewlyConnectedNodes', () => {
it('modifies promptType with ChatTrigger->new Agent', () => { it('modifies promptType with ChatTrigger->new Agent', () => {
const parent = { type: CHAT_TRIGGER_NODE_TYPE }; const parent = { type: CHAT_TRIGGER_NODE_TYPE };
const child = { type: AGENT_NODE_TYPE }; const child = { type: AGENT_NODE_TYPE };
adjustNewNodes(parent, child, { parentIsNew: false }); adjustNewNodes(parent, child, { parentIsNew: false });
expect(child).toEqual({ expect(child).toEqual({
type: AGENT_NODE_TYPE, type: AGENT_NODE_TYPE,
}); });
@ -33,7 +34,9 @@ describe('adjustNewlyConnectedNodes', () => {
it('modifies promptType with new ChatTrigger->new Agent', () => { it('modifies promptType with new ChatTrigger->new Agent', () => {
const parent = { type: CHAT_TRIGGER_NODE_TYPE }; const parent = { type: CHAT_TRIGGER_NODE_TYPE };
const child = { type: AGENT_NODE_TYPE }; const child = { type: AGENT_NODE_TYPE };
adjustNewNodes(parent, child); adjustNewNodes(parent, child);
expect(child).toEqual({ expect(child).toEqual({
type: AGENT_NODE_TYPE, type: AGENT_NODE_TYPE,
}); });
@ -42,7 +45,9 @@ describe('adjustNewlyConnectedNodes', () => {
it('does not modify promptType with ManualTrigger->new Agent', () => { it('does not modify promptType with ManualTrigger->new Agent', () => {
const parent = { type: MANUAL_TRIGGER_NODE_TYPE }; const parent = { type: MANUAL_TRIGGER_NODE_TYPE };
const child = { type: AGENT_NODE_TYPE }; const child = { type: AGENT_NODE_TYPE };
adjustNewNodes(parent, child, { parentIsNew: false }); adjustNewNodes(parent, child, { parentIsNew: false });
expect(child).toEqual({ expect(child).toEqual({
type: AGENT_NODE_TYPE, type: AGENT_NODE_TYPE,
parameters: { promptType: 'define' }, parameters: { promptType: 'define' },
@ -56,7 +61,9 @@ describe('adjustNewlyConnectedNodes', () => {
const child = { type: AGENT_NODE_TYPE }; const child = { type: AGENT_NODE_TYPE };
const parent = { type: '@n8n/n8n-nodes-langchain.memoryBufferWindow' }; const parent = { type: '@n8n/n8n-nodes-langchain.memoryBufferWindow' };
adjustNewNodes(parent, child, { childIsNew: false }); adjustNewNodes(parent, child, { childIsNew: false });
expect(parent).toEqual({ expect(parent).toEqual({
type: '@n8n/n8n-nodes-langchain.memoryBufferWindow', type: '@n8n/n8n-nodes-langchain.memoryBufferWindow',
}); });
@ -69,7 +76,9 @@ describe('adjustNewlyConnectedNodes', () => {
const child = { type: AGENT_NODE_TYPE, name: 'myAgent' }; const child = { type: AGENT_NODE_TYPE, name: 'myAgent' };
const parent = { type: '@n8n/n8n-nodes-langchain.memoryBufferWindow' }; const parent = { type: '@n8n/n8n-nodes-langchain.memoryBufferWindow' };
adjustNewNodes(parent, child, { childIsNew: false }); adjustNewNodes(parent, child, { childIsNew: false });
expect(parent).toEqual({ expect(parent).toEqual({
type: '@n8n/n8n-nodes-langchain.memoryBufferWindow', type: '@n8n/n8n-nodes-langchain.memoryBufferWindow',
parameters: { sessionIdType: 'customKey' }, parameters: { sessionIdType: 'customKey' },

2
packages/editor-ui/src/utils/connectionNodeUtils.ts
View file

@ -52,7 +52,7 @@ function adjustNewParent(parent: AddedNode, child: AddedNode) {
const workflow = getCurrentWorkflow(); const workflow = getCurrentWorkflow();
// If a memory node is added to an Agent, the memory node is actually the parent since it provides input // If a memory node is added to an Agent, the memory node is actually the parent since it provides input
// So we need to look for the Agent's parents to determine if it's a prompt provider // So we need to look for the Agent's parents to determine if there is a prompt provider
const ps = workflow.getParentNodesByDepth(child.name, 1); const ps = workflow.getParentNodesByDepth(child.name, 1);
if ( if (
!ps.some((x) => PROMPT_PROVIDER_NODE_NAMES.includes(workflow.getNode(x.name)?.type ?? '')) !ps.some((x) => PROMPT_PROVIDER_NODE_NAMES.includes(workflow.getNode(x.name)?.type ?? ''))

1
packages/editor-ui/src/views/NodeView.v2.vue
View file

@ -867,7 +867,6 @@ async function onAddNodesAndConnections(
return; return;
} }
// before here?
const addedNodes = await addNodes(nodes, { const addedNodes = await addNodes(nodes, {
dragAndDrop, dragAndDrop,
position, position,