mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2024-12-25 12:44:07 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix(beeminder Node): fix request id not being sent when creating a new datapoint

Browse source
This commit is contained in:
Jonathan Bennetts 2022-09-02 15:51:05 +01:00 committed by GitHub
parent 071ab40c9f
commit 73c5210294
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 24 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

23
packages/nodes-base/credentials/BeeminderApi.credentials.ts
View file

@ -1,4 +1,9 @@
import { ICredentialType, INodeProperties } from 'n8n-workflow';
import {
IAuthenticateGeneric,
ICredentialTestRequest,
ICredentialType,
INodeProperties,
} from 'n8n-workflow';
export class BeeminderApi implements ICredentialType {
name = 'beeminderApi';
@ -18,4 +23,20 @@ export class BeeminderApi implements ICredentialType {
default: '',
},
];
authenticate: IAuthenticateGeneric = {
type: 'generic',
properties: {
body: {
auth_token: '={{$credentials.authToken}}',
},
},
};
test: ICredentialTestRequest = {
request: {
baseURL: 'https://www.beeminder.com/api/v1',
url: `=/users/{{$credentials.user}}.json`,
},
};
}

3
packages/nodes-base/nodes/Beeminder/Beeminder.node.ts
View file

@ -8,7 +8,6 @@ import {
INodePropertyOptions,
INodeType,
INodeTypeDescription,
NodeOperationError,
} from 'n8n-workflow';
import {
@ -197,7 +196,7 @@ export class Beeminder implements INodeType {
},
{
displayName: 'Request ID',
name: 'requestId',
name: 'requestid',
type: 'string',
default: '',
placeholder: '',

6
packages/nodes-base/nodes/Beeminder/GenericFunctions.ts
View file

@ -15,10 +15,6 @@ export async function beeminderApiRequest(
query: IDataObject = {},
// tslint:disable-next-line:no-any
): Promise<any> {
const credentials = (await this.getCredentials('beeminderApi')) as IDataObject;
Object.assign(body, { auth_token: credentials.authToken });
const options: OptionsWithUri = {
method,
body,
@ -36,7 +32,7 @@ export async function beeminderApiRequest(
}
try {
return await this.helpers.request!(options);
return await this.helpers.requestWithAuthentication.call(this, 'beeminderApi', options);
} catch (error) {
throw new NodeApiError(this.getNode(), error);
}