mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2025-03-05 20:50:17 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

🐛 Fix attempt to reconnect and make IMAP node stable (#1667)

Browse source
This commit is contained in:
Omar Ajoue 2021-04-17 17:01:27 +02:00 committed by GitHub
parent 3fe52c84d5
commit 73da7998cf
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 37 additions and 24 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
packages/nodes-base/nodes/EmailReadImap.node.ts
View file

@ -354,8 +354,7 @@ export class EmailReadImap implements INodeType {
return newEmails; return newEmails;
}; };
let connection: ImapSimple; const establishConnection = (): Promise<ImapSimple> => {
const config: ImapSimpleOptions = { const config: ImapSimpleOptions = {
imap: { imap: {
user: credentials.user as string, user: credentials.user as string,
@ -366,11 +365,13 @@ export class EmailReadImap implements INodeType {
authTimeout: 20000, authTimeout: 20000,
}, },
onmail: async () => { onmail: async () => {
if (connection) {
const returnData = await getNewEmails(connection, searchCriteria); const returnData = await getNewEmails(connection, searchCriteria);
if (returnData.length) { if (returnData.length) {
this.emit([returnData]); this.emit([returnData]);
} }
}
}, },
}; };
@ -382,7 +383,19 @@ export class EmailReadImap implements INodeType {
// Connect to the IMAP server and open the mailbox // Connect to the IMAP server and open the mailbox
// that we get informed whenever a new email arrives // that we get informed whenever a new email arrives
connection = await imapConnect(config); return imapConnect(config).then(async conn => {
conn.on('error', async err => {
if (err.code.toUpperCase() === 'ECONNRESET') {
connection = await establishConnection();
}
throw err;
});
return conn;
});
};
let connection: ImapSimple = await establishConnection();
await connection.openBox(mailbox); await connection.openBox(mailbox);
// When workflow and so node gets set to inactive close the connectoin // When workflow and so node gets set to inactive close the connectoin