mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2024-11-09 22:24:05 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix(MQTT Node): Node hangs forever on failed connection (#10048)

Browse source
This commit is contained in:
Michael Kret 2024-07-17 16:50:51 +03:00 committed by GitHub
parent 8a53d6127e
commit 76c290655d
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 21 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
packages/nodes-base/nodes/MQTT/GenericFunctions.ts
View file

@ -1,5 +1,5 @@
import { connectAsync, type IClientOptions, type MqttClient } from 'mqtt';
import { randomString } from 'n8n-workflow';
import { connect, type IClientOptions, type MqttClient } from 'mqtt';
import { ApplicationError, randomString } from 'n8n-workflow';
import { formatPrivateKey } from '@utils/utilities';
interface BaseMqttCredential {
@ -49,5 +49,23 @@ export const createClient = async (credentials: MqttCredential): Promise<MqttCli
clientOptions.rejectUnauthorized = credentials.rejectUnauthorized;
}
return await connectAsync(clientOptions);
return await new Promise((resolve, reject) => {
const client = connect(clientOptions);
const onConnect = () => {
client.removeListener('connect', onConnect);
// eslint-disable-next-line @typescript-eslint/no-use-before-define
client.removeListener('error', onError);
resolve(client);
};
const onError = (error: Error) => {
client.removeListener('connect', onConnect);
client.removeListener('error', onError);
reject(new ApplicationError(error.message));
};
client.once('connect', onConnect);
client.once('error', onError);
});
};