diff --git a/packages/editor-ui/src/Interface.ts b/packages/editor-ui/src/Interface.ts index 635b983edd..ddf6af1e04 100644 --- a/packages/editor-ui/src/Interface.ts +++ b/packages/editor-ui/src/Interface.ts @@ -202,17 +202,13 @@ export interface IStartRunData { runData?: IRunData; } -export interface SubworkflowExecutionInfo { - executionId: string; - workflowId?: string; -} export interface ITableData { columns: string[]; data: GenericValue[][]; hasJson: { [key: string]: boolean }; metadata: { hasExecutionIds: boolean; - data: Array; + data: Array; }; } diff --git a/packages/editor-ui/src/components/RunData.vue b/packages/editor-ui/src/components/RunData.vue index f68ccab6e6..4110fd7ffe 100644 --- a/packages/editor-ui/src/components/RunData.vue +++ b/packages/editor-ui/src/components/RunData.vue @@ -182,7 +182,7 @@ const nodeHelpers = useNodeHelpers(); const externalHooks = useExternalHooks(); const telemetry = useTelemetry(); const i18n = useI18n(); -const { openExecutionInNewTab } = useExecutionHelpers(); +const { openRelatedExecution } = useExecutionHelpers(); const node = toRef(props, 'node'); @@ -514,7 +514,6 @@ const subWorkflowData = computed((): ITaskMetadata | null => { return null; } const metadata = get(workflowRunData.value, [node.value.name, props.runIndex, 'metadata'], null); - console.log('yo', metadata); if (!metadata?.parentExecution && !metadata?.subExecution) { return null; } @@ -1210,22 +1209,6 @@ function onSearchClear() { document.dispatchEvent(new KeyboardEvent('keyup', { key: '/' })); } -function onOpenRelatedExecution({ parentExecution, subExecution }: ITaskMetadata) { - const info = parentExecution || subExecution; - if (!info) { - return; - } - - openExecutionInNewTab(info.executionId, info.workflowId); - - telemetry.track( - parentExecution ? 'User clicked parent execution button' : 'User clicked inspect sub-workflow', - { - view: displayMode.value, - }, - ); -} - defineExpose({ enterEditMode }); @@ -1454,7 +1437,7 @@ defineExpose({ enterEditMode }); v-if="subWorkflowData && !(paneType === 'input' && hasInputOverwrite)" :class="$style.parentExecutionInfo" > - + {{ subWorkflowData.parentExecution diff --git a/packages/editor-ui/src/components/RunDataAi/RunDataAiContent.vue b/packages/editor-ui/src/components/RunDataAi/RunDataAiContent.vue index 06664a29b0..a55d9ecfed 100644 --- a/packages/editor-ui/src/components/RunDataAi/RunDataAiContent.vue +++ b/packages/editor-ui/src/components/RunDataAi/RunDataAiContent.vue @@ -12,7 +12,6 @@ import { computed } from 'vue'; import NodeIcon from '@/components/NodeIcon.vue'; import AiRunContentBlock from './AiRunContentBlock.vue'; import { useExecutionHelpers } from '@/composables/useExecutionHelpers'; -import { useTelemetry } from '@/composables/useTelemetry'; interface RunMeta { startTimeMs: number; @@ -33,9 +32,7 @@ const props = defineProps<{ const nodeTypesStore = useNodeTypesStore(); const workflowsStore = useWorkflowsStore(); -const telemetry = useTelemetry(); - -const { openExecutionInNewTab } = useExecutionHelpers(); +const { openRelatedExecution } = useExecutionHelpers(); type TokenUsageData = { completionTokens: number; @@ -111,15 +108,6 @@ const outputError = computed(() => { | NodeError | undefined; }); - -// todo unify function across components -function openExecution({ executionId, workflowId }: { workflowId: string; executionId: string }) { - openExecutionInNewTab(executionId, workflowId); - - telemetry.track('User clicked inspect sub-workflow', { - view: 'ai', - }); -}