mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2024-12-25 04:34:06 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix(editor): Reset canvas zoom before workspace reset in node view (#7625)

Browse source
This commit is contained in:
Csaba Tuncsik 2023-11-06 18:15:49 +01:00 committed by GitHub
parent 4934462b41
commit 78b84af8d1
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 1119 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

67
cypress/e2e/30-editor-after-route-changes.cy.ts
View file

@ -87,6 +87,40 @@ const editWorkflowMoreAndActivate = () => {
cy.get('.el-notification .el-notification--error').should('not.exist');
};
const switchBetweenEditorAndHistory = () => {
workflowPage.getters.workflowHistoryButton().click();
cy.wait(['@getHistory']);
cy.wait(['@getVersion']);
cy.intercept('GET', '/rest/workflows/*').as('workflowGet');
workflowHistoryPage.getters.workflowHistoryCloseButton().click();
cy.wait(['@workflowGet']);
cy.wait(1000);
workflowPage.getters.canvasNodes().first().should('be.visible');
workflowPage.getters.canvasNodes().last().should('be.visible');
}
const switchBetweenEditorAndWorkflowlist = () => {
cy.getByTestId('menu-item').first().click();
cy.wait(['@getUsers', '@getWorkflows', '@getActive', '@getCredentials']);
cy.getByTestId('resources-list-item').first().click();
workflowPage.getters.canvasNodes().first().should('be.visible');
workflowPage.getters.canvasNodes().last().should('be.visible');
}
const zoomInAndCheckNodes = () => {
cy.getByTestId('zoom-in-button').click();
cy.getByTestId('zoom-in-button').click();
cy.getByTestId('zoom-in-button').click();
cy.getByTestId('zoom-in-button').click();
workflowPage.getters.canvasNodes().first().should('not.be.visible');
workflowPage.getters.canvasNodes().last().should('not.be.visible');
}
describe('Editor actions should work', () => {
beforeEach(() => {
cy.enableFeature('debugInEditor');
@ -149,3 +183,36 @@ describe('Editor actions should work', () => {
editWorkflowMoreAndActivate();
});
});
describe('Editor zoom should work after route changes', () => {
beforeEach(() => {
cy.enableFeature('debugInEditor');
cy.enableFeature('workflowHistory');
cy.signin({ email: INSTANCE_OWNER.email, password: INSTANCE_OWNER.password });
workflowPage.actions.visit();
cy.createFixtureWorkflow('Lots_of_nodes.json', `Lots of nodes`);
workflowPage.actions.saveWorkflowOnButtonClick();
});
it('after switching between Editor and Workflow history and Workflow list', () => {
cy.intercept('GET', '/rest/workflow-history/workflow/*/version/*').as('getVersion');
cy.intercept('GET', '/rest/workflow-history/workflow/*').as('getHistory');
cy.intercept('GET', '/rest/users').as('getUsers');
cy.intercept('GET', '/rest/workflows').as('getWorkflows');
cy.intercept('GET', '/rest/active').as('getActive');
cy.intercept('GET', '/rest/credentials').as('getCredentials');
switchBetweenEditorAndHistory();
zoomInAndCheckNodes();
switchBetweenEditorAndHistory();
switchBetweenEditorAndHistory();
zoomInAndCheckNodes();
switchBetweenEditorAndWorkflowlist();
zoomInAndCheckNodes();
switchBetweenEditorAndWorkflowlist();
switchBetweenEditorAndWorkflowlist();
zoomInAndCheckNodes();
switchBetweenEditorAndHistory();
switchBetweenEditorAndWorkflowlist();
});
});

1051
cypress/fixtures/Lots_of_nodes.json Normal file
View file

File diff suppressed because it is too large Load diff

1
packages/editor-ui/src/views/NodeView.vue
View file

@ -4090,6 +4090,7 @@ export default defineComponent({
this.onToggleNodeCreator({ createNodeActive: false });
this.nodeCreatorStore.setShowScrim(false);
this.canvasStore.resetZoom();
// Reset nodes
this.unbindEndpointEventListeners();