mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2024-12-25 12:44:07 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix(core): Skip credential check of disabled nodes and improve error

Browse source 
message
This commit is contained in:
Jan Oberhauser 2022-05-02 10:01:32 +02:00
parent c02d259453
commit 79ced8f677
1 changed files with 10 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
packages/cli/src/UserManagement/UserManagementHelper.ts
View file

@ -136,6 +136,10 @@ export async function checkPermissionsForExecution(
// Iterate over all nodes // Iterate over all nodes
nodeNames.forEach((nodeName) => { nodeNames.forEach((nodeName) => {
const node = workflow.nodes[nodeName]; const node = workflow.nodes[nodeName];
if (node.disabled === true) {
// If a node is disabled there is no need to check its credentials
return;
}
// And check if any of the nodes uses credentials. // And check if any of the nodes uses credentials.
if (node.credentials) { if (node.credentials) {
const credentialNames = Object.keys(node.credentials); const credentialNames = Object.keys(node.credentials);
@ -146,9 +150,14 @@ export async function checkPermissionsForExecution(
// workflow. Nowaways it should not happen anymore. // workflow. Nowaways it should not happen anymore.
// Migrations should handle the case where a credential does // Migrations should handle the case where a credential does
// not have an id. // not have an id.
if (credentialDetail.id === null) {
throw new Error(
`The credential on node '${node.name}' is not valid. Please open the workflow and set it to a valid value.`,
);
}
if (!credentialDetail.id) { if (!credentialDetail.id) {
throw new Error( throw new Error(
'Error initializing workflow: credential ID not present. Please open the workflow and save it to fix this error.', `Error initializing workflow: credential ID not present. Please open the workflow and save it to fix this error. [Node: '${node.name}']`,
); );
} }
credentialIds.add(credentialDetail.id.toString()); credentialIds.add(credentialDetail.id.toString());