mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2025-02-02 07:01:30 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

refactor(core): Delete dead code in ExternalHooks (no-changelog) (#10100)

Browse source
This commit is contained in:
कारतोफ्फेलस्क्रिप्ट™ 2024-07-18 17:18:58 +02:00 committed by GitHub
parent 1b6c2d3a37
commit 7a135df768
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 2 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
packages/cli/src/ExternalHooks.ts
View file

@ -42,17 +42,7 @@ export class ExternalHooks {
this.initDidRun = true; this.initDidRun = true;
} }
async reload(externalHooks?: IExternalHooksFileData) { private async loadHooksFiles() {
this.externalHooks = {};
if (externalHooks === undefined) {
await this.loadHooksFiles(true);
} else {
this.loadHooks(externalHooks);
}
}
async loadHooksFiles(reload = false) {
const externalHookFiles = config.getEnv('externalHookFiles').split(':'); const externalHookFiles = config.getEnv('externalHookFiles').split(':');
// Load all the provided hook-files // Load all the provided hook-files
@ -60,10 +50,6 @@ export class ExternalHooks {
hookFilePath = hookFilePath.trim(); hookFilePath = hookFilePath.trim();
if (hookFilePath !== '') { if (hookFilePath !== '') {
try { try {
if (reload) {
delete require.cache[require.resolve(hookFilePath)];
}
const hookFile = require(hookFilePath) as IExternalHooksFileData; const hookFile = require(hookFilePath) as IExternalHooksFileData;
this.loadHooks(hookFile); this.loadHooks(hookFile);
} catch (e) { } catch (e) {
@ -78,7 +64,7 @@ export class ExternalHooks {
} }
} }
loadHooks(hookFileData: IExternalHooksFileData) { private loadHooks(hookFileData: IExternalHooksFileData) {
for (const resource of Object.keys(hookFileData)) { for (const resource of Object.keys(hookFileData)) {
for (const operation of Object.keys(hookFileData[resource])) { for (const operation of Object.keys(hookFileData[resource])) {
// Save all the hook functions directly under their string // Save all the hook functions directly under their string