mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2024-12-24 20:24:05 -08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

fix(Invoice Ninja Node): Fix assigning an invoice to a payment (#9590)

Browse source
This commit is contained in:
CodeShakingSheep 2024-07-03 14:22:48 -05:00 committed by GitHub
parent f64ca621e1
commit 7a3c127b2c
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 23 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
packages/nodes-base/nodes/InvoiceNinja/InvoiceNinja.node.ts
View file

@ -660,18 +660,31 @@ export class InvoiceNinja implements INodeType {
if (resource === 'payment') { if (resource === 'payment') {
if (operation === 'create') { if (operation === 'create') {
const additionalFields = this.getNodeParameter('additionalFields', i); const additionalFields = this.getNodeParameter('additionalFields', i);
const invoice = this.getNodeParameter('invoice', i) as number; const invoice = this.getNodeParameter('invoice', i) as number | string;
const client = ( const client = (
await invoiceNinjaApiRequest.call(this, 'GET', `/invoices/${invoice}`, {}, qs) await invoiceNinjaApiRequest.call(this, 'GET', `/invoices/${invoice}`, {}, qs)
).data?.client_id as string; ).data?.client_id as string;
const amount = this.getNodeParameter('amount', i) as number; const amount = this.getNodeParameter('amount', i) as number;
const body: IPayment = { const body: IPayment = {
invoice_id: invoice,
amount, amount,
client_id: client, client_id: client,
}; };
if (apiVersion === 'v4') {
body.invoice_id = invoice as number;
} else if (apiVersion === 'v5') {
body.invoices = [
{
invoice_id: invoice as string,
amount,
},
];
}
if (additionalFields.paymentType) { if (additionalFields.paymentType) {
body.payment_type_id = additionalFields.paymentType as number; if (apiVersion === 'v4') {
body.payment_type_id = additionalFields.paymentType as number;
} else if (apiVersion == 'v5') {
body.type_id = additionalFields.paymentType as number;
}
} }
if (additionalFields.transferReference) { if (additionalFields.transferReference) {
body.transaction_reference = additionalFields.transferReference as string; body.transaction_reference = additionalFields.transferReference as string;

7
packages/nodes-base/nodes/InvoiceNinja/PaymentInterface.ts
View file

@ -2,7 +2,14 @@ export interface IPayment {
invoice_id?: number; invoice_id?: number;
amount?: number; amount?: number;
payment_type_id?: number; payment_type_id?: number;
type_id?: number;
transaction_reference?: string; transaction_reference?: string;
private_notes?: string; private_notes?: string;
client_id?: string; client_id?: string;
invoices?: IInvoice[];
}
export interface IInvoice {
invoice_id: string;
amount: number;
} }