mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2025-03-05 20:50:17 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix(Todoist Node): Fix multiple item support (#3614)

Browse source 
* Fixed multiple items handling with todoist node

* Removed unused import
This commit is contained in:
Jonathan Bennetts 2022-07-04 08:43:56 +01:00 committed by GitHub
parent bb41f8388d
commit 7ba85c4ab9
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
packages/nodes-base/nodes/Todoist/Service.ts
View file

@ -15,8 +15,8 @@ import { IDataObject } from 'n8n-workflow';
export class TodoistService implements Service { export class TodoistService implements Service {
async execute(ctx: Context, operation: OperationType): Promise<TodoistResponse> { async execute(ctx: Context, operation: OperationType, itemIndex: number): Promise<TodoistResponse> {
return this.handlers[operation].handleOperation(ctx, 0); return this.handlers[operation].handleOperation(ctx, itemIndex);
} }
private handlers = { private handlers = {
@ -51,7 +51,7 @@ export interface Section {
} }
export interface Service { export interface Service {
execute(ctx: Context, operation: OperationType): Promise<TodoistResponse>; execute(ctx: Context, operation: OperationType, itemIndex: number): Promise<TodoistResponse>;
} }
export interface TodoistResponse { export interface TodoistResponse {

4
packages/nodes-base/nodes/Todoist/Todoist.node.ts
View file

@ -10,7 +10,7 @@ import {
INodeTypeDescription, INodeTypeDescription,
} from 'n8n-workflow'; } from 'n8n-workflow';
import {FormatDueDatetime, todoistApiRequest,} from './GenericFunctions'; import {todoistApiRequest,} from './GenericFunctions';
import {OperationType, TodoistService} from './Service'; import {OperationType, TodoistService} from './Service';
interface IBodyCreateTask { interface IBodyCreateTask {
@ -698,7 +698,7 @@ export class Todoist implements INodeType {
for (let i = 0; i < length; i++) { for (let i = 0; i < length; i++) {
try { try {
if (resource === 'task') { if (resource === 'task') {
responseData = (await service.execute(this, OperationType[operation as keyof typeof OperationType])); responseData = (await service.execute(this, OperationType[operation as keyof typeof OperationType], i));
} }
if (Array.isArray(responseData?.data)) { if (Array.isArray(responseData?.data)) {
returnData.push.apply(returnData, responseData?.data as IDataObject[]); returnData.push.apply(returnData, responseData?.data as IDataObject[]);