mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2024-12-24 20:24:05 -08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

refactor(editor): Add types for dataPinningEventBus (no-changelog) (#10499)

Browse source
This commit is contained in:
Tomi Turtiainen 2024-08-22 09:31:48 +03:00 committed by GitHub
parent 18491f6a6f
commit 7bf25ea505
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 35 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
packages/editor-ui/src/components/NodeDetailsView.vue
View file

@ -160,6 +160,7 @@ import {
STICKY_NODE_TYPE,
} from '@/constants';
import { useWorkflowActivate } from '@/composables/useWorkflowActivate';
import type { DataPinningDiscoveryEvent } from '@/event-bus';
import { dataPinningEventBus } from '@/event-bus';
import { useWorkflowsStore } from '@/stores/workflows.store';
import { useNDVStore } from '@/stores/ndv.store';
@ -238,7 +239,7 @@ const activeNodeType = computed(() => {
return null;
});
const workflowRunning = computed(() => uiStore.isActionActive['workflowRunning']);
const workflowRunning = computed(() => uiStore.isActionActive.workflowRunning);
const showTriggerWaitingWarning = computed(
() =>
@ -428,7 +429,7 @@ const featureRequestUrl = computed(() => {
const outputPanelEditMode = computed(() => ndvStore.outputPanelEditMode);
const isWorkflowRunning = computed(() => uiStore.isActionActive['workflowRunning']);
const isWorkflowRunning = computed(() => uiStore.isActionActive.workflowRunning);
const isExecutionWaitingForWebhook = computed(() => workflowsStore.executionWaitingForWebhook);
@ -458,7 +459,7 @@ const hasForeignCredential = computed(() => foreignCredentials.value.length > 0)
//methods
const setIsTooltipVisible = ({ isTooltipVisible }: { isTooltipVisible: boolean }) => {
const setIsTooltipVisible = ({ isTooltipVisible }: DataPinningDiscoveryEvent) => {
pinDataDiscoveryTooltipVisible.value = isTooltipVisible;
};

7
packages/editor-ui/src/composables/useNodeHelpers.ts
View file

@ -63,6 +63,7 @@ import { useCanvasStore } from '@/stores/canvas.store';
import { getEndpointScope } from '@/utils/nodeViewUtils';
import { useSourceControlStore } from '@/stores/sourceControl.store';
import { getConnectionInfo } from '@/utils/canvasUtils';
import type { UnpinNodeDataEvent } from '@/event-bus/data-pinning';
declare namespace HttpRequestNode {
namespace V2 {
@ -992,8 +993,8 @@ export function useNodeHelpers() {
});
}
function removePinDataConnections(pinData: IPinData) {
Object.keys(pinData).forEach((nodeName) => {
function removePinDataConnections(event: UnpinNodeDataEvent) {
for (const nodeName of event.nodeNames) {
const node = workflowsStore.getNodeByName(nodeName);
if (!node) {
return;
@ -1015,7 +1016,7 @@ export function useNodeHelpers() {
canvasStore.jsPlumbInstance.setSuspendDrawing(true);
connectionsArray.forEach(NodeViewUtils.resetConnection);
canvasStore.jsPlumbInstance.setSuspendDrawing(false, true);
});
}
}
function getOutputEndpointUUID(

22
packages/editor-ui/src/event-bus/data-pinning.ts
View file

@ -1,3 +1,23 @@
import { createEventBus } from 'n8n-design-system/utils';
import type { IPinData } from 'n8n-workflow';
export const dataPinningEventBus = createEventBus();
export type DataPinningDiscoveryEvent = {
isTooltipVisible: boolean;
};
export type UnpinNodeDataEvent = {
nodeNames: string[];
};
export interface DataPinningEventBusEvents {
/** Command to show or hide the data pinning discovery tooltip */
'data-pinning-discovery': DataPinningDiscoveryEvent;
/** Event that data has been pinned for workflow */
'pin-data': IPinData;
/** Event that data has been unpinned for specific nodes */
'unpin-data': UnpinNodeDataEvent;
}
export const dataPinningEventBus = createEventBus<DataPinningEventBusEvents>();

10
packages/editor-ui/src/stores/workflows.store.ts
View file

@ -669,14 +669,14 @@ export const useWorkflowsStore = defineStore(STORES.WORKFLOWS, () => {
};
}
function setWorkflowPinData(pinData: IPinData) {
function setWorkflowPinData(pinData?: IPinData) {
workflow.value = {
...workflow.value,
pinData: pinData || {},
pinData: pinData ?? {},
};
updateCachedWorkflow();
dataPinningEventBus.emit('pin-data', pinData || {});
dataPinningEventBus.emit('pin-data', pinData ?? {});
}
function setWorkflowTagIds(tags: string[]) {
@ -768,7 +768,9 @@ export const useWorkflowsStore = defineStore(STORES.WORKFLOWS, () => {
uiStore.stateIsDirty = true;
updateCachedWorkflow();
dataPinningEventBus.emit('unpin-data', { [payload.node.name]: undefined });
dataPinningEventBus.emit('unpin-data', {
nodeNames: [payload.node.name],
});
}
function addConnection(data: { connection: IConnection[] }): void {