mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2025-01-11 12:57:29 -08:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

🐛 Fix issue with referencing values before loops

Browse source
This commit is contained in:
Jan Oberhauser 2021-08-19 18:29:20 +02:00
parent 6bc3a20591
commit 7da86641d5
1 changed files with 13 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
packages/workflow/src/Workflow.ts
View file

@ -635,6 +635,17 @@ export class Workflow {
* @memberof Workflow * @memberof Workflow
*/ */
getNodeConnectionOutputIndex(nodeName: string, parentNodeName: string, type = 'main', depth = -1, checkedNodes?: string[]): number | undefined { getNodeConnectionOutputIndex(nodeName: string, parentNodeName: string, type = 'main', depth = -1, checkedNodes?: string[]): number | undefined {
const node = this.getNode(parentNodeName);
if (node === null) {
return undefined;
}
const nodeType = this.nodeTypes.getByName(node.type) as INodeType;
if (nodeType.description.outputs.length === 1) {
// If the parent node has only one output, it can only be connected
// to that one. So no further checking is required.
return 0;
}
depth = depth === -1 ? -1 : depth; depth = depth === -1 ? -1 : depth;
const newDepth = depth === -1 ? depth : depth - 1; const newDepth = depth === -1 ? depth : depth - 1;
if (depth === 0) { if (depth === 0) {
@ -669,8 +680,8 @@ export class Workflow {
} }
if (checkedNodes!.includes(connection.node)) { if (checkedNodes!.includes(connection.node)) {
// Node got checked already before // Node got checked already before so continue with the next one
return; continue;
} }
outputIndex = this.getNodeConnectionOutputIndex(connection.node, parentNodeName, type, newDepth, checkedNodes); outputIndex = this.getNodeConnectionOutputIndex(connection.node, parentNodeName, type, newDepth, checkedNodes);