mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2025-03-05 20:50:17 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix(editor): Fix workflow execution list scrolling after filter change (#10226)

Browse source
This commit is contained in:
Csaba Tuncsik 2024-07-31 09:09:54 +02:00 committed by GitHub
parent 3d23f2f333
commit 7e643589c6
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 47 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

44
cypress/e2e/20-workflow-executions.cy.ts
View file

@ -183,6 +183,50 @@ describe('Current Workflow Executions', () => {
.invoke('attr', 'title') .invoke('attr', 'title')
.should('eq', newWorkflowName); .should('eq', newWorkflowName);
}); });
it('should load items and auto scroll after filter change', () => {
createMockExecutions();
createMockExecutions();
cy.intercept('GET', '/rest/executions?filter=*').as('getExecutions');
executionsTab.actions.switchToExecutionsTab();
cy.wait(['@getExecutions']);
executionsTab.getters.executionsList().scrollTo(0, 500).wait(0);
executionsTab.getters.executionListItems().eq(10).click();
cy.getByTestId('executions-filter-button').click();
cy.getByTestId('executions-filter-status-select').should('be.visible').click();
getVisibleSelect().find('li:contains("Error")').click();
executionsTab.getters.executionListItems().should('have.length', 5);
executionsTab.getters.successfulExecutionListItems().should('have.length', 1);
executionsTab.getters.failedExecutionListItems().should('have.length', 4);
cy.getByTestId('executions-filter-button').click();
cy.getByTestId('executions-filter-status-select').should('be.visible').click();
getVisibleSelect().find('li:contains("Success")').click();
// check if the list is scrolled
executionsTab.getters.executionListItems().eq(10).should('be.visible');
executionsTab.getters.executionsList().then(($el) => {
const { scrollTop, scrollHeight, clientHeight } = $el[0];
expect(scrollTop).to.be.greaterThan(0);
expect(scrollTop + clientHeight).to.be.lessThan(scrollHeight);
// scroll to the bottom
$el[0].scrollTo(0, scrollHeight);
executionsTab.getters.executionListItems().should('have.length', 18);
executionsTab.getters.successfulExecutionListItems().should('have.length', 18);
executionsTab.getters.failedExecutionListItems().should('have.length', 0);
});
cy.getByTestId('executions-filter-button').click();
cy.getByTestId('executions-filter-reset-button').should('be.visible').click();
executionsTab.getters.executionListItems().eq(11).should('be.visible');
});
}); });
const createMockExecutions = () => { const createMockExecutions = () => {

3
packages/editor-ui/src/components/executions/workflow/WorkflowExecutionsSidebar.vue
View file

@ -186,6 +186,9 @@ export default defineComponent({
this.$emit('refresh'); this.$emit('refresh');
}, },
onFilterChanged(filter: ExecutionFilterType) { onFilterChanged(filter: ExecutionFilterType) {
this.autoScrollDeps.activeExecutionSet = false;
this.autoScrollDeps.scroll = true;
this.mountedItems = [];
this.$emit('filterUpdated', filter); this.$emit('filterUpdated', filter);
}, },
reloadExecutions(): void { reloadExecutions(): void {