mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2025-03-05 20:50:17 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

add error handling for unknon operations

Browse source
This commit is contained in:
quansenB 2019-10-25 16:30:58 +02:00
parent 4f1a096139
commit 819efc50e5
1 changed files with 21 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

37
packages/nodes-base/nodes/ActiveCampaign/ActiveCampaign.node.ts
View file

@ -755,7 +755,7 @@ export class ActiveCampaign implements INodeType {
}, },
] ]
}, },
// ---------------------------------- // ----------------------------------
// deal:delete // deal:delete
// ---------------------------------- // ----------------------------------
@ -1026,6 +1026,8 @@ export class ActiveCampaign implements INodeType {
const updateFields = this.getNodeParameter('updateFields', i) as IDataObject; const updateFields = this.getNodeParameter('updateFields', i) as IDataObject;
addAdditionalFields(body.contact as IDataObject, updateFields); addAdditionalFields(body.contact as IDataObject, updateFields);
} else {
throw new Error(`The operation ${operation} is not known`);
} }
} else if (resource === 'deal') { } else if (resource === 'deal') {
if (operation === 'create') { if (operation === 'create') {
@ -1102,23 +1104,26 @@ export class ActiveCampaign implements INodeType {
dataKey = 'deals'; dataKey = 'deals';
endpoint = `/api/3/deals`; endpoint = `/api/3/deals`;
} else { } else {
throw new Error(`The resource "${resource}" is not known!`); throw new Error(`The operation ${operation} is not known`);
}
let responseData;
if (returnAll === true) {
responseData = await activeCampaignApiRequestAllItems.call(this, requestMethod, endpoint, body, qs, dataKey);
} else {
responseData = await activeCampaignApiRequest.call(this, requestMethod, endpoint, body, qs, dataKey);
}
if (Array.isArray(responseData)) {
returnData.push.apply(returnData, responseData as IDataObject[]);
} else {
returnData.push(responseData as IDataObject);
} }
} else {
throw new Error(`The resource "${resource}" is not known!`);
} }
return [this.helpers.returnJsonArray(returnData)]; let responseData;
if (returnAll === true) {
responseData = await activeCampaignApiRequestAllItems.call(this, requestMethod, endpoint, body, qs, dataKey);
} else {
responseData = await activeCampaignApiRequest.call(this, requestMethod, endpoint, body, qs, dataKey);
}
if (Array.isArray(responseData)) {
returnData.push.apply(returnData, responseData as IDataObject[]);
} else {
returnData.push(responseData as IDataObject);
}
} }
return [this.helpers.returnJsonArray(returnData)];
} }
}