mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2024-11-10 06:34:05 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

⚡ Improve error message on GithubTrigger #162

Browse source
This commit is contained in:
Jan Oberhauser 2019-12-23 07:29:28 -06:00
parent a7bc500343
commit 81ca11cb59
1 changed files with 6 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
packages/nodes-base/nodes/Github/GithubTrigger.node.ts
View file

@ -332,7 +332,11 @@ export class GithubTrigger implements INodeType {
return true;
},
async create(this: IHookFunctions): Promise<boolean> {
const webhookUrl = this.getNodeWebhookUrl('default');
const webhookUrl = this.getNodeWebhookUrl('default') as string;
if (webhookUrl.includes('//localhost')) {
throw new Error('The Webhook can not work on "localhost". Please, either setup n8n on a custom domain or start with "--tunnel"!');
}
const owner = this.getNodeParameter('owner') as string;
const repository = this.getNodeParameter('repository') as string;
@ -377,7 +381,7 @@ export class GithubTrigger implements INodeType {
}
}
throw new Error('A webhook with the identical URL exists already. Please delete it manually on Github!');
throw new Error('A webhook with the identical URL probably exists already. Please delete it manually on Github!');
}
throw e;