mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2024-12-25 20:54:07 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Remove executeSingle from FunctionItem node

Browse source
This commit is contained in:
dali 2021-02-17 08:51:02 +01:00
parent 735a7e6812
commit 81f33b4c04
1 changed files with 67 additions and 57 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

138
packages/nodes-base/nodes/FunctionItem.node.ts
View file

@ -1,4 +1,4 @@
import { IExecuteSingleFunctions } from 'n8n-core'; import { IExecuteFunctions } from 'n8n-core';
import { import {
IBinaryKeyData, IBinaryKeyData,
IDataObject, IDataObject,
@ -40,74 +40,84 @@ export class FunctionItem implements INodeType {
], ],
}; };
async executeSingle(this: IExecuteSingleFunctions): Promise<INodeExecutionData> { async execute(this: IExecuteFunctions): Promise<INodeExecutionData[][]> {
let item = this.getInputData(); const items = this.getInputData();
// Copy the items as they may get changed in the functions const returnData: INodeExecutionData[] = [];
item = JSON.parse(JSON.stringify(item)); const length = items.length as unknown as number;
let item: INodeExecutionData;
// Define the global objects for the custom function for (let itemIndex = 0; itemIndex < length; itemIndex++) {
const sandbox = {
getBinaryData: (): IBinaryKeyData | undefined => {
return item.binary;
},
getNodeParameter: this.getNodeParameter,
getWorkflowStaticData: this.getWorkflowStaticData,
helpers: this.helpers,
item: item.json,
setBinaryData: (data: IBinaryKeyData) => {
item.binary = data;
},
};
// Make it possible to access data via $node, $parameter, ... item = items[itemIndex];
const dataProxy = this.getWorkflowDataProxy();
Object.assign(sandbox, dataProxy);
const options = { // Copy the items as they may get changed in the functions
console: 'inherit', item = JSON.parse(JSON.stringify(item));
sandbox,
require: {
external: false as boolean | { modules: string[] },
builtin: [] as string[],
},
};
if (process.env.NODE_FUNCTION_ALLOW_BUILTIN) { // Define the global objects for the custom function
options.require.builtin = process.env.NODE_FUNCTION_ALLOW_BUILTIN.split(','); const sandbox = {
getBinaryData: (): IBinaryKeyData | undefined => {
return item.binary;
},
getNodeParameter: this.getNodeParameter,
getWorkflowStaticData: this.getWorkflowStaticData,
helpers: this.helpers,
item: item.json,
setBinaryData: (data: IBinaryKeyData) => {
item.binary = data;
},
};
// Make it possible to access data via $node, $parameter, ...
const dataProxy = this.getWorkflowDataProxy(itemIndex);
Object.assign(sandbox, dataProxy);
const options = {
console: 'inherit',
sandbox,
require: {
external: false as boolean | { modules: string[] },
builtin: [] as string[],
},
};
if (process.env.NODE_FUNCTION_ALLOW_BUILTIN) {
options.require.builtin = process.env.NODE_FUNCTION_ALLOW_BUILTIN.split(',');
}
if (process.env.NODE_FUNCTION_ALLOW_EXTERNAL) {
options.require.external = { modules: process.env.NODE_FUNCTION_ALLOW_EXTERNAL.split(',') };
}
const vm = new NodeVM(options);
// Get the code to execute
const functionCode = this.getNodeParameter('functionCode', itemIndex) as string;
let jsonData: IDataObject;
try {
// Execute the function code
jsonData = await vm.run(`module.exports = async function() {${functionCode}}()`, __dirname);
} catch (e) {
return Promise.reject(e);
}
// Do very basic validation of the data
if (jsonData === undefined) {
throw new Error('No data got returned. Always an object has to be returned!');
}
const returnItem: INodeExecutionData = {
json: jsonData,
};
if (item.binary) {
returnItem.binary = item.binary;
}
returnData.push(returnItem);
} }
return this.prepareOutputData(returnData);
if (process.env.NODE_FUNCTION_ALLOW_EXTERNAL) {
options.require.external = { modules: process.env.NODE_FUNCTION_ALLOW_EXTERNAL.split(',') };
}
const vm = new NodeVM(options);
// Get the code to execute
const functionCode = this.getNodeParameter('functionCode') as string;
let jsonData: IDataObject;
try {
// Execute the function code
jsonData = await vm.run(`module.exports = async function() {${functionCode}}()`, __dirname);
} catch (e) {
return Promise.reject(e);
}
// Do very basic validation of the data
if (jsonData === undefined) {
throw new Error('No data got returned. Always an object has to be returned!');
}
const returnItem: INodeExecutionData = {
json: jsonData,
};
if (item.binary) {
returnItem.binary = item.binary;
}
return returnItem;
} }
} }