From 8494c978213378efc2aed7326d1444745db416cc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Milorad=20FIlipovi=C4=87?= Date: Fri, 10 Feb 2023 13:12:06 +0100 Subject: [PATCH] test(editor): Add e2e tests for personal settings page (#5451) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ✅ Added tests for personal user settings --- cypress/e2e/18-user-management.cy.ts | 52 +++++++++++++++++++ cypress/pages/modals/change-password-modal.ts | 12 +++++ cypress/pages/settings-personal.ts | 52 +++++++++++++++++++ .../src/components/ChangePasswordModal.vue | 1 + .../src/views/SettingsPersonalView.vue | 9 ++-- 5 files changed, 122 insertions(+), 4 deletions(-) create mode 100644 cypress/pages/modals/change-password-modal.ts create mode 100644 cypress/pages/settings-personal.ts diff --git a/cypress/e2e/18-user-management.cy.ts b/cypress/e2e/18-user-management.cy.ts index 6c0f9c84d4..f01cee7844 100644 --- a/cypress/e2e/18-user-management.cy.ts +++ b/cypress/e2e/18-user-management.cy.ts @@ -1,6 +1,7 @@ import { MainSidebar } from './../pages/sidebar/main-sidebar'; import { DEFAULT_USER_EMAIL, DEFAULT_USER_PASSWORD } from '../constants'; import { SettingsSidebar, SettingsUsersPage, WorkflowPage, WorkflowsPage } from '../pages'; +import { PersonalSettingsPage } from '../pages/settings-personal'; /** * User A - Instance owner @@ -36,8 +37,17 @@ const users = [ }, ]; +const updatedPersonalData = { + newFirstName: 'Something', + newLastName: 'Else', + newEmail: 'something_else@acme.corp', + newPassword: 'Keybo4rd', + invalidPasswords: ['abc', 'longEnough', 'longenough123'] +} + const usersSettingsPage = new SettingsUsersPage(); const workflowPage = new WorkflowPage(); +const personalSettingsPage = new PersonalSettingsPage(); describe('User Management', () => { before(() => { @@ -93,4 +103,46 @@ describe('User Management', () => { usersSettingsPage.getters.deleteUserButton().realClick(); workflowPage.getters.successToast().should('contain', 'User deleted'); }); + + it(`should allow user to change their personal data`, () => { + personalSettingsPage.actions.loginAndVisit(instanceOwner.email, instanceOwner.password); + personalSettingsPage.actions.updateFirstAndLastName(updatedPersonalData.newFirstName, updatedPersonalData.newLastName); + personalSettingsPage.getters.currentUserName().should('contain', `${updatedPersonalData.newFirstName} ${updatedPersonalData.newLastName}`); + workflowPage.getters.successToast().should('contain', 'Personal details updated'); + }); + + it(`shouldn't allow user to set weak password`, () => { + personalSettingsPage.actions.loginAndVisit(instanceOwner.email, instanceOwner.password); + for (let weakPass of updatedPersonalData.invalidPasswords) { + personalSettingsPage.actions.tryToSetWeakPassword(instanceOwner.password, weakPass); + } + }); + + it(`shouldn't allow user to change password if old password is wrong`, () => { + personalSettingsPage.actions.loginAndVisit(instanceOwner.email, instanceOwner.password); + personalSettingsPage.actions.updatePassword('iCannotRemember', updatedPersonalData.newPassword); + workflowPage.getters.errorToast().closest('div').should('contain', 'Provided current password is incorrect.'); + }); + + it(`should change current user password`, () => { + personalSettingsPage.actions.loginAndVisit(instanceOwner.email, instanceOwner.password); + personalSettingsPage.actions.updatePassword(instanceOwner.password, updatedPersonalData.newPassword); + workflowPage.getters.successToast().should('contain', 'Password updated'); + personalSettingsPage.actions.loginWithNewData(instanceOwner.email, updatedPersonalData.newPassword); + }); + + it(`shouldn't allow users to set invalid email`, () => { + personalSettingsPage.actions.loginAndVisit(instanceOwner.email, updatedPersonalData.newPassword); + // try without @ part + personalSettingsPage.actions.tryToSetInvalidEmail(updatedPersonalData.newEmail.split('@')[0]); + // try without domain + personalSettingsPage.actions.tryToSetInvalidEmail(updatedPersonalData.newEmail.split('.')[0]); + }); + + it(`should change user email`, () => { + personalSettingsPage.actions.loginAndVisit(instanceOwner.email, updatedPersonalData.newPassword); + personalSettingsPage.actions.updateEmail(updatedPersonalData.newEmail); + workflowPage.getters.successToast().should('contain', 'Personal details updated'); + personalSettingsPage.actions.loginWithNewData(updatedPersonalData.newEmail, updatedPersonalData.newPassword); + }); }); diff --git a/cypress/pages/modals/change-password-modal.ts b/cypress/pages/modals/change-password-modal.ts new file mode 100644 index 0000000000..3e9ebc8697 --- /dev/null +++ b/cypress/pages/modals/change-password-modal.ts @@ -0,0 +1,12 @@ +import { BasePage } from './../base'; + +export class ChangePasswordModal extends BasePage { + getters = { + modalContainer: () => cy.getByTestId('changePassword-modal').last(), + currentPasswordInput: () => cy.getByTestId('currentPassword').find('input').first(), + newPasswordInputContainer: () => cy.getByTestId('password'), + newPasswordInput: () => cy.getByTestId('password').find('input').first(), + repeatPasswordInput: () => cy.getByTestId('password2').find('input').first(), + changePasswordButton: () => cy.getByTestId('change-password-button'), + }; +} diff --git a/cypress/pages/settings-personal.ts b/cypress/pages/settings-personal.ts new file mode 100644 index 0000000000..a454837011 --- /dev/null +++ b/cypress/pages/settings-personal.ts @@ -0,0 +1,52 @@ +import { ChangePasswordModal } from './modals/change-password-modal'; +import { BasePage } from './base'; + +const changePasswordModal = new ChangePasswordModal(); + +export class PersonalSettingsPage extends BasePage { + url = '/settings/personal'; + getters = { + currentUserName: () => cy.getByTestId('current-user-name'), + firstNameInput: () => cy.getByTestId('firstName').find('input').first(), + lastNameInput: () => cy.getByTestId('lastName').find('input').first(), + emailInputContainer: () => cy.getByTestId('email'), + emailInput: () => cy.getByTestId('email').find('input').first(), + changePasswordLink: () => cy.getByTestId('change-password-link').find('a').first(), + saveSettingsButton: () => cy.getByTestId('save-settings-button'), + }; + actions = { + loginAndVisit: (email: string, password: string) => { + cy.signin({ email, password }); + cy.visit(this.url); + }, + updateFirstAndLastName: (newFirstName: string, newLastName: string) => { + this.getters.firstNameInput().type('{selectall}').type(newFirstName); + this.getters.lastNameInput().type('{selectall}').type(newLastName); + this.getters.saveSettingsButton().realClick(); + }, + updatePassword: (oldPassword: string, newPassword: string) => { + this.getters.changePasswordLink().realClick(); + changePasswordModal.getters.modalContainer().should('be.visible'); + changePasswordModal.getters.currentPasswordInput().type('{selectall}').type(oldPassword); + changePasswordModal.getters.newPasswordInput().type('{selectall}').type(newPassword); + changePasswordModal.getters.repeatPasswordInput().type('{selectall}').type(newPassword); + changePasswordModal.getters.changePasswordButton().click(); + }, + tryToSetWeakPassword: (oldPassword: string, newPassword: string) => { + this.actions.updatePassword(oldPassword, newPassword); + changePasswordModal.getters.newPasswordInputContainer().find('div[class^="_errorInput"]').should('exist'); + }, + updateEmail: (newEmail: string) => { + this.getters.emailInput().type('{selectall}').type(newEmail).type('{enter}'); + }, + tryToSetInvalidEmail: (newEmail: string) => { + this.actions.updateEmail(newEmail); + this.getters.emailInputContainer().find('div[class^="_errorInput"]').should('exist'); + }, + loginWithNewData: (email: string, password: string) => { + cy.signout(); + this.actions.loginAndVisit(email, password); + cy.url().should('match', new RegExp(this.url)); + }, + }; +} diff --git a/packages/editor-ui/src/components/ChangePasswordModal.vue b/packages/editor-ui/src/components/ChangePasswordModal.vue index b6e00d35e7..7e404b3328 100644 --- a/packages/editor-ui/src/components/ChangePasswordModal.vue +++ b/packages/editor-ui/src/components/ChangePasswordModal.vue @@ -22,6 +22,7 @@ :label="$locale.baseText('auth.changePassword')" @click="onSubmitClick" float="right" + data-test-id="change-password-button" /> diff --git a/packages/editor-ui/src/views/SettingsPersonalView.vue b/packages/editor-ui/src/views/SettingsPersonalView.vue index 86c7b14e2a..ef6cc55220 100644 --- a/packages/editor-ui/src/views/SettingsPersonalView.vue +++ b/packages/editor-ui/src/views/SettingsPersonalView.vue @@ -1,11 +1,11 @@