mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2024-12-25 04:34:06 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix(editor): Don't render pinned icon for disabled nodes (#10712)

Browse source
This commit is contained in:
Raúl Gómez Morales 2024-09-06 14:48:03 +02:00 committed by GitHub
parent 43713dcd89
commit 879b837581
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 14 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
packages/editor-ui/src/components/canvas/elements/nodes/render-types/parts/CanvasNodeStatusIcons.spec.ts
View file

@ -18,6 +18,18 @@ describe('CanvasNodeStatusIcons', () => {
expect(getByTestId('canvas-node-status-pinned')).toBeInTheDocument(); expect(getByTestId('canvas-node-status-pinned')).toBeInTheDocument();
}); });
it('should not render pinned icon when disabled', () => {
const { queryByTestId } = renderComponent({
global: {
provide: createCanvasNodeProvide({
data: { disabled: true, pinnedData: { count: 5, visible: true } },
}),
},
});
expect(queryByTestId('canvas-node-status-pinned')).not.toBeInTheDocument();
});
it('should render correctly for a running node', () => { it('should render correctly for a running node', () => {
const { getByTestId } = renderComponent({ const { getByTestId } = renderComponent({
global: { global: {

3
packages/editor-ui/src/components/canvas/elements/nodes/render-types/parts/CanvasNodeStatusIcons.vue
View file

@ -15,6 +15,7 @@ const {
executionRunning, executionRunning,
hasRunData, hasRunData,
runDataIterations, runDataIterations,
isDisabled,
} = useCanvasNode(); } = useCanvasNode();
const hideNodeIssues = computed(() => false); // @TODO Implement this const hideNodeIssues = computed(() => false); // @TODO Implement this
@ -45,7 +46,7 @@ const hideNodeIssues = computed(() => false); // @TODO Implement this
</N8nTooltip> </N8nTooltip>
</div> </div>
<div <div
v-else-if="hasPinnedData && !nodeHelpers.isProductionExecutionPreview.value" v-else-if="hasPinnedData && !nodeHelpers.isProductionExecutionPreview.value && !isDisabled"
data-test-id="canvas-node-status-pinned" data-test-id="canvas-node-status-pinned"
:class="[$style.status, $style.pinnedData]" :class="[$style.status, $style.pinnedData]"
> >