mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2024-12-25 20:54:07 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix: Add template id to workflows created from templates (no-changelog) (#8226)

Browse source 
In #8088 template ID was added to workflow metadata, but it was missing
from workflows that were created using the template credential setup.
This fixes that.
This commit is contained in:
Tomi Turtiainen 2024-01-05 10:36:59 +02:00 committed by GitHub
parent 071e6d6b6e
commit 8a78ae1739
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 20 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
cypress/e2e/34-template-credentials-setup.cy.ts
View file

@ -106,6 +106,22 @@ describe('Template credentials setup', () => {
cy.wait('@createWorkflow'); cy.wait('@createWorkflow');
workflowPage.getters.canvasNodes().should('have.length', 3); workflowPage.getters.canvasNodes().should('have.length', 3);
// Focus the canvas so the copy to clipboard works
workflowPage.getters.canvasNodes().eq(0).realClick();
workflowPage.actions.selectAll();
workflowPage.actions.hitCopy();
cy.grantBrowserPermissions('clipboardReadWrite', 'clipboardSanitizedWrite');
// Check workflow JSON by copying it to clipboard
cy.readClipboard().then((workflowJSON) => {
const workflow = JSON.parse(workflowJSON);
expect(workflow.meta).to.haveOwnProperty('templateId', testTemplate.id.toString());
workflow.nodes.forEach((node: any) => {
expect(Object.keys(node.credentials ?? {})).to.have.lengthOf(1);
});
});
}); });
it('should work with a template that has no credentials (ADO-1603)', () => { it('should work with a template that has no credentials (ADO-1603)', () => {

5
packages/editor-ui/src/utils/templates/templateActions.ts
View file

@ -37,7 +37,10 @@ export async function createWorkflowFromTemplate(opts: {
nodes, nodes,
connections, connections,
active: false, active: false,
// Ignored: pinData, settings, tags, versionId, meta meta: {
templateId: template.id.toString(),
},
// Ignored: pinData, settings, tags, versionId
}; };
const createdWorkflow = await workflowsStore.createNewWorkflow(workflowToCreate); const createdWorkflow = await workflowsStore.createNewWorkflow(workflowToCreate);