mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2025-03-05 20:50:17 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

feat(Matrix Node): Allow setting filename if the binary data has none (#6536)

Browse source
This commit is contained in:
Jon 2023-06-26 16:37:40 +01:00 committed by GitHub
parent b66d151066
commit 8b76e98085
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 31 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
packages/nodes-base/nodes/Matrix/GenericFunctions.ts
View file

@ -189,6 +189,7 @@ export async function handleMatrixCall(
const roomId = this.getNodeParameter('roomId', index) as string;
const mediaType = this.getNodeParameter('mediaType', index) as string;
const binaryPropertyName = this.getNodeParameter('binaryPropertyName', index);
const additionalFields = this.getNodeParameter('additionalFields', index);
let body;
const qs: IDataObject = {};
@ -197,7 +198,12 @@ export async function handleMatrixCall(
const { fileName, mimeType } = this.helpers.assertBinaryData(index, binaryPropertyName);
body = await this.helpers.getBinaryDataBuffer(index, binaryPropertyName);
qs.filename = fileName;
if (additionalFields.fileName) {
qs.filename = additionalFields.fileName as string;
} else {
qs.filename = fileName;
}
headers['Content-Type'] = mimeType;
headers.accept = 'application/json,text/*;q=0.99';
@ -216,7 +222,7 @@ export async function handleMatrixCall(
body = {
msgtype: `m.${mediaType}`,
body: fileName,
body: qs.filename,
url: uploadRequestResult.content_uri,
};
const messageId = uuid();

24
packages/nodes-base/nodes/Matrix/MediaDescription.ts
View file

@ -81,8 +81,30 @@ export const mediaFields: INodeProperties[] = [
description: 'Image media type',
},
],
description: 'Name of the uploaded file',
description: 'Type of file being uploaded',
placeholder: 'mxc://matrix.org/uploaded-media-uri',
required: true,
},
{
displayName: 'Additional Fields',
name: 'additionalFields',
type: 'collection',
placeholder: 'Add Field',
default: {},
displayOptions: {
show: {
resource: ['media'],
operation: ['upload'],
},
},
options: [
{
displayName: 'File Name',
name: 'fileName',
type: 'string',
default: '',
description: 'Name of the file being uploaded',
},
],
},
];