From 8c4040dc5b6cb3f3d1ba0303f082fdbfc3cf2c25 Mon Sep 17 00:00:00 2001 From: Jan Oberhauser Date: Fri, 5 Nov 2021 11:19:23 -0600 Subject: [PATCH] :zap: Minor improvements to RespondToWebhook node --- packages/cli/src/NodeTypes.ts | 3 +++ packages/nodes-base/nodes/Wait.node.ts | 14 +++++++------- 2 files changed, 10 insertions(+), 7 deletions(-) diff --git a/packages/cli/src/NodeTypes.ts b/packages/cli/src/NodeTypes.ts index b6ed97511d..ff4e8c027c 100644 --- a/packages/cli/src/NodeTypes.ts +++ b/packages/cli/src/NodeTypes.ts @@ -40,6 +40,9 @@ class NodeTypesClass implements INodeTypes { } getByNameAndVersion(nodeType: string, version?: number): INodeType { + if (this.nodeTypes[nodeType] === undefined) { + throw new Error(`The node-type "${nodeType}" is not known!`); + } return NodeHelpers.getVersionedTypeNode(this.nodeTypes[nodeType].type, version); } } diff --git a/packages/nodes-base/nodes/Wait.node.ts b/packages/nodes-base/nodes/Wait.node.ts index e8c3609b1b..78279c5417 100644 --- a/packages/nodes-base/nodes/Wait.node.ts +++ b/packages/nodes-base/nodes/Wait.node.ts @@ -283,7 +283,7 @@ export class Wait implements INodeType { description: 'The HTTP Response code to return', }, { - displayName: 'Respond When', + displayName: 'Respond', name: 'responseMode', type: 'options', displayOptions: { @@ -295,19 +295,19 @@ export class Wait implements INodeType { }, options: [ { - name: 'Webhook received', + name: 'Immediately', value: 'onReceived', - description: 'Returns directly with defined Response Code', + description: 'As soon as this node executes', }, { - name: 'Last node finishes', + name: 'When last node finishes', value: 'lastNode', - description: 'Returns data of the last executed node', + description: 'Returns data of the last-executed node', }, { - name: 'Response Node finishes', + name: 'Using \'Respond to Webhook\' node', value: 'responseNode', - description: 'Returns data the response node did set', + description: 'Response defined in that node', }, ], default: 'onReceived',