From 8c7f39907fa82fa37af4436511d4a2daaff13015 Mon Sep 17 00:00:00 2001 From: Omar Ajoue Date: Wed, 10 Jan 2024 15:56:04 +0000 Subject: [PATCH] fix: Properly output saml validation errors (#8284) --- packages/cli/src/sso/saml/samlValidator.ts | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/packages/cli/src/sso/saml/samlValidator.ts b/packages/cli/src/sso/saml/samlValidator.ts index ff35c0f4cb..66be4c98e0 100644 --- a/packages/cli/src/sso/saml/samlValidator.ts +++ b/packages/cli/src/sso/saml/samlValidator.ts @@ -88,7 +88,13 @@ export async function validateMetadata(metadata: string): Promise { return true; } else { logger.warn('SAML Validate Metadata: Invalid metadata'); - logger.warn(validationResult ? validationResult.errors.join('\n') : ''); + logger.warn( + validationResult + ? validationResult.errors + .map((error) => `${error.message} - ${error.rawMessage}`) + .join('\n') + : '', + ); } } catch (error) { // eslint-disable-next-line @typescript-eslint/no-unsafe-argument @@ -118,7 +124,13 @@ export async function validateResponse(response: string): Promise { return true; } else { logger.warn('SAML Validate Response: Failed'); - logger.warn(validationResult ? validationResult.errors.join('\n') : ''); + logger.warn( + validationResult + ? validationResult.errors + .map((error) => `${error.message} - ${error.rawMessage}`) + .join('\n') + : '', + ); } } catch (error) { // eslint-disable-next-line @typescript-eslint/no-unsafe-argument