mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2025-01-11 12:57:29 -08:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

fix(editor): Fix an infinite loop while loading executions that are not on the current executions list (#5071)

Browse source 
fix(editor): Fix an infinitine loop while loading executions that are not on the current executions list
This commit is contained in:
कारतोफ्फेलस्क्रिप्ट™ 2023-01-03 14:40:51 +01:00 committed by GitHub
parent 0ec66bfb42
commit 8cf3c86860
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
packages/editor-ui/src/components/ExecutionsView/ExecutionsView.vue
View file

@ -426,9 +426,9 @@ export default mixins(
.catch(() => {}); .catch(() => {});
} }
}, },
async tryToFindExecution(executionId: string, skipCheck = false): Promise<void> { async tryToFindExecution(executionId: string, attemptCount = 0): Promise<void> {
// First check if executions exists in the DB at all // First check if executions exists in the DB at all
if (!skipCheck) { if (attemptCount === 0) {
const executionExists = await this.workflowsStore.fetchExecutionDataById(executionId); const executionExists = await this.workflowsStore.fetchExecutionDataById(executionId);
if (!executionExists) { if (!executionExists) {
this.workflowsStore.activeWorkflowExecution = null; this.workflowsStore.activeWorkflowExecution = null;
@ -443,6 +443,10 @@ export default mixins(
return; return;
} }
} }
// stop if the execution wasn't found in the first 1000 lookups
if (attemptCount >= 10) return;
// Fetch next batch of executions // Fetch next batch of executions
await this.loadMore(100); await this.loadMore(100);
const execution = this.workflowsStore.getExecutionDataById(executionId); const execution = this.workflowsStore.getExecutionDataById(executionId);
@ -450,7 +454,7 @@ export default mixins(
// If it's not there load next until found // If it's not there load next until found
await this.$nextTick(); await this.$nextTick();
// But skip fetching execution data since we at this point know it exists // But skip fetching execution data since we at this point know it exists
await this.tryToFindExecution(executionId, true); await this.tryToFindExecution(executionId, attemptCount + 1);
} else { } else {
// When found set execution as active // When found set execution as active
this.workflowsStore.activeWorkflowExecution = execution; this.workflowsStore.activeWorkflowExecution = execution;