mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2025-03-05 20:50:17 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

chore: Upgrade nodelinter to 1.16.3 (#11286)

Browse source
This commit is contained in:
Iván Ovejero 2024-10-18 09:22:24 +02:00 committed by GitHub
parent a042d5c8e6
commit 8e5292cf6c
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
11 changed files with 12 additions and 18 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
packages/nodes-base/nodes/Code/JsCodeValidator.ts
View file

@ -37,7 +37,7 @@ export function mapItemsNotDefinedErrorIfNeededForRunForAll(code: string, error:
// anticipate user expecting `items` to pre-exist as in Function Item node // anticipate user expecting `items` to pre-exist as in Function Item node
if (error.message === 'items is not defined' && !/(let|const|var) +items +=/.test(code)) { if (error.message === 'items is not defined' && !/(let|const|var) +items +=/.test(code)) {
const quoted = error.message.replace('items', '`items`'); const quoted = error.message.replace('items', '`items`');
error.message = (quoted as string) + '. Did you mean `$input.all()`?'; error.message = quoted + '. Did you mean `$input.all()`?';
} }
} }
@ -49,6 +49,6 @@ export function mapItemNotDefinedErrorIfNeededForRunForEach(code: string, error:
// anticipate user expecting `items` to pre-exist as in Function Item node // anticipate user expecting `items` to pre-exist as in Function Item node
if (error.message === 'item is not defined' && !/(let|const|var) +item +=/.test(code)) { if (error.message === 'item is not defined' && !/(let|const|var) +item +=/.test(code)) {
const quoted = error.message.replace('item', '`item`'); const quoted = error.message.replace('item', '`item`');
error.message = (quoted as string) + '. Did you mean `$input.item.json`?'; error.message = quoted + '. Did you mean `$input.item.json`?';
} }
} }

1
packages/nodes-base/nodes/DebugHelper/DebugHelper.node.ts
View file

@ -277,7 +277,6 @@ export class DebugHelper implements INodeType {
message: throwErrorMessage, message: throwErrorMessage,
}); });
case 'Error': case 'Error':
// eslint-disable-next-line n8n-nodes-base/node-execute-block-wrong-error-thrown
throw new ApplicationError(throwErrorMessage); throw new ApplicationError(throwErrorMessage);
default: default:
break; break;

1
packages/nodes-base/nodes/EmailReadImap/v2/EmailReadImapV2.node.ts
View file

@ -677,7 +677,6 @@ export class EmailReadImapV2 implements INodeType {
if (connection.closeBox) await connection.closeBox(false); if (connection.closeBox) await connection.closeBox(false);
connection.end(); connection.end();
} catch (error) { } catch (error) {
// eslint-disable-next-line n8n-nodes-base/node-execute-block-wrong-error-thrown
throw new TriggerCloseError(this.getNode(), { cause: error as Error, level: 'warning' }); throw new TriggerCloseError(this.getNode(), { cause: error as Error, level: 'warning' });
} }
}; };

2
packages/nodes-base/nodes/Google/Sheet/v2/actions/sheet/append.operation.ts
View file

@ -230,7 +230,7 @@ export async function execute(
const sheetNameWithRangeForKeyRow = `${sheetNameForKeyRow}!1:${keyRowIndex}`; const sheetNameWithRangeForKeyRow = `${sheetNameForKeyRow}!1:${keyRowIndex}`;
const sheetData = await sheet.getData(sheetNameWithRangeForKeyRow, 'FORMATTED_VALUE'); const sheetData = await sheet.getData(sheetNameWithRangeForKeyRow, 'FORMATTED_VALUE');
if (sheetData === undefined || !sheetData.length) { if (!sheetData?.length) {
dataMode = 'autoMapInputData'; dataMode = 'autoMapInputData';
} }

4
packages/nodes-base/nodes/InvoiceNinja/InvoiceNinja.node.ts
View file

@ -1056,10 +1056,10 @@ export class InvoiceNinja implements INodeType {
const paymentId = this.getNodeParameter('paymentId', i) as string; const paymentId = this.getNodeParameter('paymentId', i) as string;
const body: IBankTransaction = {}; const body: IBankTransaction = {};
if (bankTransactionId) { if (bankTransactionId) {
body.id = bankTransactionId as string; body.id = bankTransactionId;
} }
if (paymentId) { if (paymentId) {
body.paymentId = paymentId as string; body.paymentId = paymentId;
} }
responseData = await invoiceNinjaApiRequest.call( responseData = await invoiceNinjaApiRequest.call(
this, this,

1
packages/nodes-base/nodes/Kafka/Kafka.node.ts
View file

@ -229,7 +229,6 @@ export class Kafka implements INodeType {
}; };
if (credentials.authentication === true) { if (credentials.authentication === true) {
if (!(credentials.username && credentials.password)) { if (!(credentials.username && credentials.password)) {
// eslint-disable-next-line n8n-nodes-base/node-execute-block-wrong-error-thrown
throw new ApplicationError('Username and password are required for authentication', { throw new ApplicationError('Username and password are required for authentication', {
level: 'warning', level: 'warning',
}); });

1
packages/nodes-base/nodes/MongoDb/MongoDb.node.ts
View file

@ -81,7 +81,6 @@ export class MongoDb implements INodeType {
const { databases } = await client.db().admin().listDatabases(); const { databases } = await client.db().admin().listDatabases();
if (!(databases as IDataObject[]).map((db) => db.name).includes(database)) { if (!(databases as IDataObject[]).map((db) => db.name).includes(database)) {
// eslint-disable-next-line n8n-nodes-base/node-execute-block-wrong-error-thrown
throw new ApplicationError(`Database "${database}" does not exist`, { throw new ApplicationError(`Database "${database}" does not exist`, {
level: 'warning', level: 'warning',
}); });

3
packages/nodes-base/nodes/Postgres/PostgresTrigger.node.ts
View file

@ -290,7 +290,7 @@ export class PostgresTrigger implements INodeType {
await connection.query('SELECT 1'); await connection.query('SELECT 1');
} catch { } catch {
// connection already closed. Can't perform cleanup // connection already closed. Can't perform cleanup
// eslint-disable-next-line n8n-nodes-base/node-execute-block-wrong-error-thrown
throw new TriggerCloseError(this.getNode(), { level: 'warning' }); throw new TriggerCloseError(this.getNode(), { level: 'warning' });
} }
@ -316,7 +316,6 @@ export class PostgresTrigger implements INodeType {
]); ]);
} }
} catch (error) { } catch (error) {
// eslint-disable-next-line n8n-nodes-base/node-execute-block-wrong-error-thrown
throw new TriggerCloseError(this.getNode(), { cause: error as Error, level: 'error' }); throw new TriggerCloseError(this.getNode(), { cause: error as Error, level: 'error' });
} }
} finally { } finally {

1
packages/nodes-base/nodes/Transform/RemoveDuplicates/v1/RemoveDuplicatesV1.node.ts
View file

@ -1,4 +1,3 @@
/* eslint-disable n8n-nodes-base/node-filename-against-convention */
import { NodeConnectionType } from 'n8n-workflow'; import { NodeConnectionType } from 'n8n-workflow';
import type { import type {
INodeTypeBaseDescription, INodeTypeBaseDescription,

2
packages/nodes-base/package.json
View file

@ -840,7 +840,7 @@
"@types/ssh2-sftp-client": "^5.1.0", "@types/ssh2-sftp-client": "^5.1.0",
"@types/uuid": "catalog:", "@types/uuid": "catalog:",
"@types/xml2js": "catalog:", "@types/xml2js": "catalog:",
"eslint-plugin-n8n-nodes-base": "^1.16.2", "eslint-plugin-n8n-nodes-base": "^1.16.3",
"n8n-core": "workspace:*" "n8n-core": "workspace:*"
}, },
"dependencies": { "dependencies": {

10
pnpm-lock.yaml
View file

@ -1850,8 +1850,8 @@ importers:
specifier: 'catalog:' specifier: 'catalog:'
version: 0.4.14 version: 0.4.14
eslint-plugin-n8n-nodes-base: eslint-plugin-n8n-nodes-base:
specifier: ^1.16.2 specifier: ^1.16.3
version: 1.16.2(eslint@8.57.0)(typescript@5.6.2) version: 1.16.3(eslint@8.57.0)(typescript@5.6.2)
n8n-core: n8n-core:
specifier: workspace:* specifier: workspace:*
version: link:../core version: link:../core
@ -7145,8 +7145,8 @@ packages:
eslint-plugin-n8n-local-rules@1.0.0: eslint-plugin-n8n-local-rules@1.0.0:
resolution: {integrity: sha512-qe6sVFDP1Vj5eXlqZxYZpIjwYvhuqXlI0P8OfPyhiPOhMkFtr0TpFphD8/6WCzkm7LJCvG1eJEzURCtMIsFTAg==} resolution: {integrity: sha512-qe6sVFDP1Vj5eXlqZxYZpIjwYvhuqXlI0P8OfPyhiPOhMkFtr0TpFphD8/6WCzkm7LJCvG1eJEzURCtMIsFTAg==}
eslint-plugin-n8n-nodes-base@1.16.2: eslint-plugin-n8n-nodes-base@1.16.3:
resolution: {integrity: sha512-Qj8S+YgymYkt/5Fr1buwOTjl0jAERJBp3MA5V8M6NR1HYfErKazVjpOPEy5+04c0vAQZO1mPLGAzanxqqNUIng==} resolution: {integrity: sha512-edLX42Vg4B+y0kzkitTVDmHZQrG5/wUZO874N5Z9leBuxt5TG1pqMY4zdr35RlpM4p4REr/T9x+6DpsQSL63WA==}
engines: {node: '>=20.15', pnpm: '>=9.6'} engines: {node: '>=20.15', pnpm: '>=9.6'}
eslint-plugin-unicorn@51.0.1: eslint-plugin-unicorn@51.0.1:
@ -19382,7 +19382,7 @@ snapshots:
eslint-plugin-n8n-local-rules@1.0.0: {} eslint-plugin-n8n-local-rules@1.0.0: {}
eslint-plugin-n8n-nodes-base@1.16.2(eslint@8.57.0)(typescript@5.6.2): eslint-plugin-n8n-nodes-base@1.16.3(eslint@8.57.0)(typescript@5.6.2):
dependencies: dependencies:
'@typescript-eslint/utils': 6.21.0(eslint@8.57.0)(typescript@5.6.2) '@typescript-eslint/utils': 6.21.0(eslint@8.57.0)(typescript@5.6.2)
camel-case: 4.1.2 camel-case: 4.1.2