From 8fb31e84591b6bd02314ecef58b1135ea003390b Mon Sep 17 00:00:00 2001 From: Tomi Turtiainen <10324676+tomi@users.noreply.github.com> Date: Thu, 19 Sep 2024 16:21:55 +0300 Subject: [PATCH] fix(benchmark): Simplify binary data scenario setup and use larger binary file (#10879) --- .../benchmark/scenarios/binary-data/binary-data.script.js | 5 +++-- packages/@n8n/benchmark/src/test-execution/k6-executor.ts | 1 - 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/@n8n/benchmark/scenarios/binary-data/binary-data.script.js b/packages/@n8n/benchmark/scenarios/binary-data/binary-data.script.js index 95867245bf..c10e667cbb 100644 --- a/packages/@n8n/benchmark/scenarios/binary-data/binary-data.script.js +++ b/packages/@n8n/benchmark/scenarios/binary-data/binary-data.script.js @@ -3,8 +3,9 @@ import { check } from 'k6'; const apiBaseUrl = __ENV.API_BASE_URL; -const file = open(__ENV.SCRIPT_FILE_PATH, 'b'); -const filename = String(__ENV.SCRIPT_FILE_PATH).split('/').pop(); +// This creates a 2MB file (16 * 128 * 1024 = 2 * 1024 * 1024 = 2MB) +const file = Array.from({ length: 128 * 1024 }, () => Math.random().toString().slice(2)).join(''); +const filename = 'test.bin'; export default function () { const data = { diff --git a/packages/@n8n/benchmark/src/test-execution/k6-executor.ts b/packages/@n8n/benchmark/src/test-execution/k6-executor.ts index 4fcf11d45b..42161c76ba 100644 --- a/packages/@n8n/benchmark/src/test-execution/k6-executor.ts +++ b/packages/@n8n/benchmark/src/test-execution/k6-executor.ts @@ -77,7 +77,6 @@ export function handleSummary(data) { env: { API_BASE_URL: this.opts.n8nApiBaseUrl, K6_CLOUD_TOKEN: this.opts.k6ApiToken, - SCRIPT_FILE_PATH: augmentedTestScriptPath, }, stdio: 'inherit', })`${k6ExecutablePath} run ${flattedFlags} ${augmentedTestScriptPath}`;