mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2024-11-12 15:44:06 -08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

fix(editor): Fix RunData non-binary pagination when binary data is present (#11309)

Browse source
This commit is contained in:
Charlie Kolb 2024-10-22 11:00:34 +02:00 committed by GitHub
parent 45274f2e7f
commit 901888d5b1
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 41 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
packages/editor-ui/src/components/RunData.vue
View file

@ -1745,7 +1745,7 @@ export default defineComponent({
v-if="
hasNodeRun &&
!hasRunError &&
binaryData.length === 0 &&
displayMode !== 'binary' &&
dataCount > pageSize &&
!isSchemaView &&
!isArtificialRecoveredEventItem

40
packages/editor-ui/src/components/__tests__/RunData.test.ts
View file

@ -154,6 +154,46 @@ describe('RunData', () => {
expect(pinDataButton).toBeEnabled();
});
it('should not render pagination on binary tab', async () => {
const { queryByTestId } = render(
Array.from({ length: 11 }).map((_, i) => ({
json: {
data: {
id: i,
name: `Test ${i}`,
},
},
binary: {
data: {
a: 'b',
},
},
})),
'binary',
);
expect(queryByTestId('ndv-data-pagination')).not.toBeInTheDocument();
});
it('should render pagination with binary data on non-binary tab', async () => {
const { getByTestId } = render(
Array.from({ length: 11 }).map((_, i) => ({
json: {
data: {
id: i,
name: `Test ${i}`,
},
},
binary: {
data: {
a: 'b',
},
},
})),
'json',
);
expect(getByTestId('ndv-data-pagination')).toBeInTheDocument();
});
const render = (
outputData: unknown[],
displayMode: IRunDataDisplayMode,