mirror of
https://github.com/n8n-io/n8n.git
synced 2025-03-05 20:50:17 -08:00
feat(core): Add package name tag to Sentry errors (no-changelog) (#7958)
## Summary Add `packageName` tag to errors reported to Sentry, for filtering ... #### How to test the change: 1. ... ## Issues fixed Include links to Github issue or Community forum post or **Linear ticket**: > Important in order to close automatically and provide context to reviewers ... ## Review / Merge checklist - [ ] PR title and summary are descriptive. **Remember, the title automatically goes into the changelog. Use `(no-changelog)` otherwise.** ([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md)) - [ ] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up ticket created. - [ ] Tests included. > A bug is not considered fixed, unless a test is added to prevent it from happening again. A feature is not complete without tests. > > *(internal)* You can use Slack commands to trigger [e2e tests](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#a39f9e5ba64a48b58a71d81c837e8227) or [deploy test instance](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#f6a177d32bde4b57ae2da0b8e454bfce) or [deploy early access version on Cloud](https://www.notion.so/n8n/Cloudbot-3dbe779836004972b7057bc989526998?pvs=4#fef2d36ab02247e1a0f65a74f6fb534e).
This commit is contained in:
parent
3206b44974
commit
90824b50ed
|
@ -40,10 +40,11 @@ export const initErrorHandling = async () => {
|
||||||
const seenErrors = new Set<string>();
|
const seenErrors = new Set<string>();
|
||||||
addGlobalEventProcessor((event, { originalException }) => {
|
addGlobalEventProcessor((event, { originalException }) => {
|
||||||
if (originalException instanceof ApplicationError) {
|
if (originalException instanceof ApplicationError) {
|
||||||
const { level, extra } = originalException;
|
const { level, extra, tags } = originalException;
|
||||||
if (level === 'warning') return null;
|
if (level === 'warning') return null;
|
||||||
event.level = level;
|
event.level = level;
|
||||||
if (extra) event.extra = { ...event.extra, ...extra };
|
if (extra) event.extra = { ...event.extra, ...extra };
|
||||||
|
if (tags) event.tags = { ...event.tags, ...tags };
|
||||||
}
|
}
|
||||||
|
|
||||||
if (!event.exception) return null;
|
if (!event.exception) return null;
|
||||||
|
|
|
@ -51,6 +51,7 @@
|
||||||
"@n8n/tournament": "1.0.2",
|
"@n8n/tournament": "1.0.2",
|
||||||
"@n8n_io/riot-tmpl": "4.0.0",
|
"@n8n_io/riot-tmpl": "4.0.0",
|
||||||
"ast-types": "0.15.2",
|
"ast-types": "0.15.2",
|
||||||
|
"callsites": "3.1.0",
|
||||||
"crypto-js": "4.2.0",
|
"crypto-js": "4.2.0",
|
||||||
"deep-equal": "2.2.0",
|
"deep-equal": "2.2.0",
|
||||||
"esprima-next": "5.8.4",
|
"esprima-next": "5.8.4",
|
||||||
|
|
|
@ -1,3 +1,4 @@
|
||||||
|
import callsites from 'callsites';
|
||||||
import type { Event } from '@sentry/node';
|
import type { Event } from '@sentry/node';
|
||||||
|
|
||||||
type Level = 'warning' | 'error' | 'fatal';
|
type Level = 'warning' | 'error' | 'fatal';
|
||||||
|
@ -13,13 +14,22 @@ export class ApplicationError extends Error {
|
||||||
|
|
||||||
readonly extra?: Event['extra'];
|
readonly extra?: Event['extra'];
|
||||||
|
|
||||||
|
readonly packageName?: string;
|
||||||
|
|
||||||
constructor(
|
constructor(
|
||||||
message: string,
|
message: string,
|
||||||
{ level, tags, extra, ...rest }: Partial<ErrorOptions> & ReportingOptions = {},
|
{ level, tags = {}, extra, ...rest }: Partial<ErrorOptions> & ReportingOptions = {},
|
||||||
) {
|
) {
|
||||||
super(message, rest);
|
super(message, rest);
|
||||||
this.level = level ?? 'error';
|
this.level = level ?? 'error';
|
||||||
this.tags = tags;
|
this.tags = tags;
|
||||||
this.extra = extra;
|
this.extra = extra;
|
||||||
|
|
||||||
|
try {
|
||||||
|
const filePath = callsites()[2].getFileName() ?? '';
|
||||||
|
const match = /packages\/([^\/]+)\//.exec(filePath)?.[1];
|
||||||
|
|
||||||
|
if (match) this.tags.packageName = match;
|
||||||
|
} catch {}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
|
@ -1563,6 +1563,9 @@ importers:
|
||||||
ast-types:
|
ast-types:
|
||||||
specifier: 0.15.2
|
specifier: 0.15.2
|
||||||
version: 0.15.2
|
version: 0.15.2
|
||||||
|
callsites:
|
||||||
|
specifier: 3.1.0
|
||||||
|
version: 3.1.0
|
||||||
crypto-js:
|
crypto-js:
|
||||||
specifier: 4.2.0
|
specifier: 4.2.0
|
||||||
version: 4.2.0
|
version: 4.2.0
|
||||||
|
@ -8866,7 +8869,7 @@ packages:
|
||||||
ts-dedent: 2.2.0
|
ts-dedent: 2.2.0
|
||||||
type-fest: 2.19.0
|
type-fest: 2.19.0
|
||||||
vue: 3.3.4
|
vue: 3.3.4
|
||||||
vue-component-type-helpers: 1.8.24
|
vue-component-type-helpers: 1.8.25
|
||||||
transitivePeerDependencies:
|
transitivePeerDependencies:
|
||||||
- encoding
|
- encoding
|
||||||
- supports-color
|
- supports-color
|
||||||
|
@ -11392,7 +11395,7 @@ packages:
|
||||||
/axios@0.21.4:
|
/axios@0.21.4:
|
||||||
resolution: {integrity: sha512-ut5vewkiu8jjGBdqpM44XxjuCjq9LAKeHVmoVfHVzy8eHgxxq8SbAVQNovDA8mVi05kP0Ea/n/UzcSHcTJQfNg==}
|
resolution: {integrity: sha512-ut5vewkiu8jjGBdqpM44XxjuCjq9LAKeHVmoVfHVzy8eHgxxq8SbAVQNovDA8mVi05kP0Ea/n/UzcSHcTJQfNg==}
|
||||||
dependencies:
|
dependencies:
|
||||||
follow-redirects: 1.15.2(debug@4.3.4)
|
follow-redirects: 1.15.2(debug@3.2.7)
|
||||||
transitivePeerDependencies:
|
transitivePeerDependencies:
|
||||||
- debug
|
- debug
|
||||||
dev: false
|
dev: false
|
||||||
|
@ -11421,11 +11424,12 @@ packages:
|
||||||
form-data: 4.0.0
|
form-data: 4.0.0
|
||||||
transitivePeerDependencies:
|
transitivePeerDependencies:
|
||||||
- debug
|
- debug
|
||||||
|
dev: true
|
||||||
|
|
||||||
/axios@1.4.0:
|
/axios@1.4.0:
|
||||||
resolution: {integrity: sha512-S4XCWMEmzvo64T9GfvQDOXgYRDJ/wsSZc7Jvdgx5u1sd0JwsuPLqb3SYmusag+edF6ziyMensPVqLTSc1PiSEA==}
|
resolution: {integrity: sha512-S4XCWMEmzvo64T9GfvQDOXgYRDJ/wsSZc7Jvdgx5u1sd0JwsuPLqb3SYmusag+edF6ziyMensPVqLTSc1PiSEA==}
|
||||||
dependencies:
|
dependencies:
|
||||||
follow-redirects: 1.15.2(debug@4.3.4)
|
follow-redirects: 1.15.2(debug@3.2.7)
|
||||||
form-data: 4.0.0
|
form-data: 4.0.0
|
||||||
proxy-from-env: 1.1.0
|
proxy-from-env: 1.1.0
|
||||||
transitivePeerDependencies:
|
transitivePeerDependencies:
|
||||||
|
@ -15138,6 +15142,7 @@ packages:
|
||||||
optional: true
|
optional: true
|
||||||
dependencies:
|
dependencies:
|
||||||
debug: 4.3.4(supports-color@8.1.1)
|
debug: 4.3.4(supports-color@8.1.1)
|
||||||
|
dev: true
|
||||||
|
|
||||||
/for-each@0.3.3:
|
/for-each@0.3.3:
|
||||||
resolution: {integrity: sha512-jqYfLp7mo9vIyQf8ykW2v7A+2N4QjeCeI5+Dz9XraiO1ign81wjiH7Fb9vSOWvQfNtmSa4H2RoQTrrXivdUZmw==}
|
resolution: {integrity: sha512-jqYfLp7mo9vIyQf8ykW2v7A+2N4QjeCeI5+Dz9XraiO1ign81wjiH7Fb9vSOWvQfNtmSa4H2RoQTrrXivdUZmw==}
|
||||||
|
@ -21222,7 +21227,7 @@ packages:
|
||||||
resolution: {integrity: sha512-aXYe/D+28kF63W8Cz53t09ypEORz+ULeDCahdAqhVrRm2scbOXFbtnn0GGhvMpYe45grepLKuwui9KxrZ2ZuMw==}
|
resolution: {integrity: sha512-aXYe/D+28kF63W8Cz53t09ypEORz+ULeDCahdAqhVrRm2scbOXFbtnn0GGhvMpYe45grepLKuwui9KxrZ2ZuMw==}
|
||||||
engines: {node: '>=14.17.0'}
|
engines: {node: '>=14.17.0'}
|
||||||
dependencies:
|
dependencies:
|
||||||
axios: 0.27.2(debug@4.3.4)
|
axios: 0.27.2(debug@3.2.7)
|
||||||
transitivePeerDependencies:
|
transitivePeerDependencies:
|
||||||
- debug
|
- debug
|
||||||
dev: false
|
dev: false
|
||||||
|
@ -25320,8 +25325,8 @@ packages:
|
||||||
vue: 3.3.4
|
vue: 3.3.4
|
||||||
dev: false
|
dev: false
|
||||||
|
|
||||||
/vue-component-type-helpers@1.8.24:
|
/vue-component-type-helpers@1.8.25:
|
||||||
resolution: {integrity: sha512-lqWs/7fdRXoSBAlbouHBX+LNuaY6gI9xWW34m/ZIz9zVPYHEyw0b2/zaCBwlKx0NtKTeF/6pOpvrxVkh7nhIYg==}
|
resolution: {integrity: sha512-NCA6sekiJIMnMs4DdORxATXD+/NRkQpS32UC+I1KQJUasx+Z7MZUb3Y+MsKsFmX+PgyTYSteb73JW77AibaCCw==}
|
||||||
dev: true
|
dev: true
|
||||||
|
|
||||||
/vue-component-type-helpers@1.8.4:
|
/vue-component-type-helpers@1.8.4:
|
||||||
|
|
Loading…
Reference in a new issue