From 77ab283af3f50f4c72d65564fd7d7c14d11e74fa Mon Sep 17 00:00:00 2001 From: Philipp Ballhausen Date: Fri, 17 Jan 2020 14:06:11 +0100 Subject: [PATCH 1/2] fixes typo in Mattermost.node.ts --- packages/nodes-base/nodes/Mattermost/Mattermost.node.ts | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/nodes-base/nodes/Mattermost/Mattermost.node.ts b/packages/nodes-base/nodes/Mattermost/Mattermost.node.ts index fd936e9276..06f2e12c8d 100644 --- a/packages/nodes-base/nodes/Mattermost/Mattermost.node.ts +++ b/packages/nodes-base/nodes/Mattermost/Mattermost.node.ts @@ -656,8 +656,8 @@ export class Mattermost implements INodeType { }, options: [ { - name: 'Desactive', - value: 'desactive', + name: 'Deactive', + value: 'deactive', description: 'Deactivates the user and revokes all its sessions by archiving its user object.', }, ], @@ -665,7 +665,7 @@ export class Mattermost implements INodeType { description: 'The operation to perform.', }, // ---------------------------------- - // user:desactivate + // user:deactivate // ---------------------------------- { displayName: 'User ID', @@ -678,7 +678,7 @@ export class Mattermost implements INodeType { 'user', ], operation: [ - 'desactive', + 'deactive', ], }, }, From a00de109394bf8a32493b2e03ac51d37b82f583b Mon Sep 17 00:00:00 2001 From: Jan Oberhauser Date: Fri, 17 Jan 2020 07:26:59 -0600 Subject: [PATCH 2/2] :zap: Also fix Mattermost desactive typo in execute-function --- packages/nodes-base/nodes/Mattermost/Mattermost.node.ts | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/packages/nodes-base/nodes/Mattermost/Mattermost.node.ts b/packages/nodes-base/nodes/Mattermost/Mattermost.node.ts index 06f2e12c8d..5026955952 100644 --- a/packages/nodes-base/nodes/Mattermost/Mattermost.node.ts +++ b/packages/nodes-base/nodes/Mattermost/Mattermost.node.ts @@ -900,9 +900,12 @@ export class Mattermost implements INodeType { Object.assign(body, otherOptions); } } else if (resource === 'user') { - if (operation === 'desactive') { + // TODO: Remove the "deactive" again in the future. In here temporary + // to not break workflows for people which set the option before + // typo got fixed. JO 2020-01-17 + if (operation === 'deactive' || operation === 'desactive') { // ---------------------------------- - // user:desactive + // user:deactive // ---------------------------------- const userId = this.getNodeParameter('userId', i) as string; requestMethod = 'DELETE';