mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2024-12-24 04:04:06 -08:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

fix(HTTP Request Node): Fix typos in JSON validation error message (no-changelog) (#11197)

Browse source 
Co-authored-by: Jonathan Bennetts <jonathan.bennetts@gmail.com>
This commit is contained in:
Justin Ellingwood 2024-10-10 11:32:17 +01:00 committed by GitHub
parent eb2d1ca357
commit 9431e3029c
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 9 additions and 17 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
packages/cli/src/eventbus/message-event-bus-destination/message-event-bus-destination-webhook.ee.ts
View file

@ -180,7 +180,7 @@ export class MessageEventBusDestinationWebhook
try { try {
JSON.parse(this.jsonQuery); JSON.parse(this.jsonQuery);
} catch { } catch {
this.logger.error('JSON parameter need to be an valid JSON'); this.logger.error('JSON parameter needs to be valid JSON');
} }
this.axiosRequestOptions.params = jsonParse(this.jsonQuery); this.axiosRequestOptions.params = jsonParse(this.jsonQuery);
} }
@ -198,7 +198,7 @@ export class MessageEventBusDestinationWebhook
try { try {
JSON.parse(this.jsonHeaders); JSON.parse(this.jsonHeaders);
} catch { } catch {
this.logger.error('JSON parameter need to be an valid JSON'); this.logger.error('JSON parameter needs to be valid JSON');
} }
this.axiosRequestOptions.headers = jsonParse(this.jsonHeaders); this.axiosRequestOptions.headers = jsonParse(this.jsonHeaders);
} }

22
packages/nodes-base/nodes/HttpRequest/V3/HttpRequestV3.node.ts
View file

@ -340,7 +340,7 @@ export class HttpRequestV3 implements INodeType {
} catch { } catch {
throw new NodeOperationError( throw new NodeOperationError(
this.getNode(), this.getNode(),
'JSON parameter need to be an valid JSON', 'JSON parameter needs to be valid JSON',
{ {
itemIndex, itemIndex,
}, },
@ -404,13 +404,9 @@ export class HttpRequestV3 implements INodeType {
try { try {
JSON.parse(jsonQueryParameter); JSON.parse(jsonQueryParameter);
} catch { } catch {
throw new NodeOperationError( throw new NodeOperationError(this.getNode(), 'JSON parameter needs to be valid JSON', {
this.getNode(), itemIndex,
'JSON parameter need to be an valid JSON', });
{
itemIndex,
},
);
} }
requestOptions.qs = jsonParse(jsonQueryParameter); requestOptions.qs = jsonParse(jsonQueryParameter);
@ -430,13 +426,9 @@ export class HttpRequestV3 implements INodeType {
try { try {
JSON.parse(jsonHeadersParameter); JSON.parse(jsonHeadersParameter);
} catch { } catch {
throw new NodeOperationError( throw new NodeOperationError(this.getNode(), 'JSON parameter needs to be valid JSON', {
this.getNode(), itemIndex,
'JSON parameter need to be an valid JSON', });
{
itemIndex,
},
);
} }
additionalHeaders = jsonParse(jsonHeadersParameter); additionalHeaders = jsonParse(jsonHeadersParameter);