Enhance test definition creation and editing with description support

• Add description to test definition interface
• Include description in create/update params
• Update UI to handle description field
• Refactor types for better consistency
• Add data-test-id for E2E testing

packages/editor-ui/src/api/evaluations.ee.ts

@@ -10,20 +10,17 @@ export interface ITestDefinitionBase {
 	annotationTagId?: string;
 }
 
-// Complete test definition with ID
 export interface ITestDefinition extends ITestDefinitionBase {
 	id: number;
 }
 
-// Create params - requires name and workflowId, optional evaluationWorkflowId
+export type CreateTestDefinitionParams = Pick<
-export type CreateTestDefinitionParams = Pick<ITestDefinitionBase, 'name' | 'workflowId'> &
+	ITestDefinitionBase,
-	Partial<Pick<ITestDefinitionBase, 'evaluationWorkflowId'>>;
+	'name' | 'workflowId' | 'description' | 'evaluationWorkflowId'
-
-// All fields optional except ID
-export type UpdateTestDefinitionParams = Partial<
-	Pick<ITestDefinitionBase, 'name' | 'evaluationWorkflowId' | 'annotationTagId'>
 >;
 
+export type UpdateTestDefinitionParams = Partial<ITestDefinitionBase>;
+
 // Query options type
 export interface ITestDefinitionsQueryOptions {
 	includeScopes?: boolean;
@@ -58,18 +55,15 @@ export function createTestDefinitionsApi(): ITestDefinitionsApi {
 		getTestDefinitions: async (
 			context: IRestApiContext,
 			options?: ITestDefinitionsQueryOptions,
-		): Promise<ITestDefinition[]> => {
+		) => {
 			return await makeRestApiRequest(context, 'GET', endpoint, options);
 		},
 
-		getTestDefinition: async (context: IRestApiContext, id: number): Promise<ITestDefinition> => {
+		getTestDefinition: async (context: IRestApiContext, id: number) => {
 			return await makeRestApiRequest(context, 'GET', `${endpoint}/${id}`);
 		},
 
-		createTestDefinition: async (
+		createTestDefinition: async (context: IRestApiContext, params: CreateTestDefinitionParams) => {
-			context: IRestApiContext,
-			params: CreateTestDefinitionParams,
-		): Promise<ITestDefinition> => {
 			return await makeRestApiRequest(context, 'POST', endpoint, params);
 		},
 
@@ -77,14 +71,11 @@ export function createTestDefinitionsApi(): ITestDefinitionsApi {
 			context: IRestApiContext,
 			id: number,
 			params: UpdateTestDefinitionParams,
-		): Promise<ITestDefinition> => {
+		) => {
 			return await makeRestApiRequest(context, 'PATCH', `${endpoint}/${id}`, params);
 		},
 
-		deleteTestDefinition: async (
+		deleteTestDefinition: async (context: IRestApiContext, id: number) => {
-			context: IRestApiContext,
-			id: number,
-		): Promise<{ success: boolean }> => {
 			return await makeRestApiRequest(context, 'DELETE', `${endpoint}/${id}`);
 		},
 	};

packages/editor-ui/src/components/WorkflowEvaluation/EditEvaluation/TagsInput.vue

@@ -42,13 +42,18 @@ function updateTags(tags: string[]) {
 </script>
 
 <template>
-	<div :class="$style.formGroup">
+	<div :class="$style.formGroup" data-test-id="workflow-tags-field">
 		<n8n-input-label label="Tag name" :bold="false" size="small">
 			<div v-if="!modelValue.isEditing" :class="$style.tagsRead" @click="startEditing('tags')">
 				<n8n-text v-if="modelValue.appliedTagIds.length === 0" size="small">
 					{{ locale.baseText('workflowEvaluation.edit.selectTag') }}
 				</n8n-text>
-				<n8n-tag v-for="tagId in modelValue.appliedTagIds" :key="tagId" :text="getTagName(tagId)" />
+				<n8n-tag
+					v-for="tagId in modelValue.appliedTagIds"
+					:key="tagId"
+					:text="getTagName(tagId)"
+					data-test-id="evaluation-tag-field"
+				/>
 				<n8n-icon-button
 					:class="$style.editInputButton"
 					icon="pen"

packages/editor-ui/src/components/WorkflowEvaluation/composables/useEvaluationForm.ts

@@ -69,7 +69,7 @@ export function useEvaluationForm() {
 
 			if (testDefinition) {
 				state.value = {
-					description: '',
+					description: testDefinition.description ?? '',
 					name: {
 						value: testDefinition.name,
 						isEditing: false,
@@ -113,6 +113,7 @@ export function useEvaluationForm() {
 			// Prepare the base parameters for creating or updating a test
 			const params: Record<string, string> = {
 				name: state.value.name.value,
+				description: state.value.description,
 			};
 
 			// Add annotation tag ID only for PATH requests

packages/editor-ui/src/stores/evaluations.store.ee.ts

@@ -95,6 +95,7 @@ export const useEvaluationsStore = defineStore(
 			name: string;
 			workflowId: string;
 			evaluationWorkflowId?: string;
+			description?: string;
 		}) => {
 			const createdDefinition = await testDefinitionsApi.createTestDefinition(
 				rootStore.restApiContext,
@@ -107,6 +108,7 @@ export const useEvaluationsStore = defineStore(
 		const update = async (params: {
 			id: number;
 			name?: string;
+			description?: string;
 			evaluationWorkflowId?: string;
 			annotationTagId?: string;
 		}) => {